Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10837338: Remove "GData" prefix from non-GData specific classes (Closed)

Created:
8 years, 4 months ago by kochi
Modified:
8 years, 4 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, derat+watch_chromium.org, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, kinuko, Daniel Erat
Visibility:
Public.

Description

Remove "GData" prefix from non-GData specific classes - GDataOperationRegistry to OperationRegistry - GDataAuthService to AuthService - GDataOperationRunner to OperationRunner BUG=137151 TEST=pass all existing tests. TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152531

Patch Set 1 #

Total comments: 6

Patch Set 2 : rebase. #

Total comments: 9

Patch Set 3 : Fix for comments. #

Patch Set 4 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -1509 lines) Patch
M chrome/browser/chromeos/extensions/external_filesystem_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 5 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/chromeos/gdata/auth_service.h View 1 2 6 chunks +12 lines, -12 lines 0 comments Download
A + chrome/browser/chromeos/gdata/auth_service.cc View 1 2 7 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_operations.h View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_operations.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_service.h View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_api_service.cc View 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gdata/drive_service_interface.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_auth_service.h View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_auth_service.cc View 1 chunk +0 lines, -131 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_contacts_service.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_contacts_service.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_contacts_service_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/gdata/gdata_operation_registry.h View 1 chunk +0 lines, -181 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_operation_registry.cc View 1 chunk +0 lines, -348 lines 0 comments Download
chrome/browser/chromeos/gdata/gdata_operation_registry_unittest.cc View 1 2 3 1 chunk +0 lines, -258 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_operation_runner.h View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/chromeos/gdata/gdata_operation_runner.cc View 1 chunk +0 lines, -99 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operations.h View 1 2 3 17 chunks +20 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operations.cc View 17 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_operations_unittest.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_protocol_handler.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_service.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_wapi_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gdata/mock_drive_service.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/gdata/operation_registry.h View 5 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/chromeos/gdata/operation_registry.cc View 19 chunks +37 lines, -37 lines 0 comments Download
A + chrome/browser/chromeos/gdata/operation_registry_unittest.cc View 1 2 3 10 chunks +38 lines, -38 lines 0 comments Download
A + chrome/browser/chromeos/gdata/operation_runner.h View 3 chunks +15 lines, -15 lines 0 comments Download
A + chrome/browser/chromeos/gdata/operation_runner.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/gdata/operations_base.h View 1 2 3 8 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/gdata/operations_base.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 8 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kochi
Hi Satoru, Could you review this CL? This applies on top of previous CLs: https://chromiumcodereview.appspot.com/10829375/ ...
8 years, 4 months ago (2012-08-20 11:12:03 UTC) #1
satorux1
LGTM with nits http://codereview.chromium.org/10837338/diff/1/chrome/browser/chromeos/gdata/auth_service.cc File chrome/browser/chromeos/gdata/auth_service.cc (right): http://codereview.chromium.org/10837338/diff/1/chrome/browser/chromeos/gdata/auth_service.cc#newcode112 chrome/browser/chromeos/gdata/auth_service.cc:112: const content::NotificationDetails& details) { indentation. http://codereview.chromium.org/10837338/diff/1/chrome/browser/chromeos/gdata/auth_service.h ...
8 years, 4 months ago (2012-08-20 17:00:47 UTC) #2
kochi
Thanks for the review! Addressed all the comments. Added TBR=ben@chromium.org for gypi review. https://chromiumcodereview.appspot.com/10837338/diff/1/chrome/browser/chromeos/gdata/auth_service.cc File ...
8 years, 4 months ago (2012-08-21 05:09:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/10837338/3006
8 years, 4 months ago (2012-08-21 05:10:36 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-21 08:00:10 UTC) #5 
Try job failure for 10837338-3006 (retry) on win_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698