Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10837331: Options: s/options2/options/. (Closed)

Created:
8 years, 4 months ago by James Hawkins
Modified:
8 years, 4 months ago
Reviewers:
csilv
CC:
chromium-reviews
Visibility:
Public.

Description

Options: s/options2/options/. BUG=122251 R=csilv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152280

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase. #

Patch Set 3 : Really rebase. #

Patch Set 4 : wut #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -19238 lines) Patch
M chrome/app/generated_resources.grd View 6 chunks +13 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/options/OWNERS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/advanced_options_utils.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options/advanced_options_utils_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/advanced_options_utils_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/advanced_options_utils_x11.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/autofill_options_browsertest.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/autofill_options_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/browser_options_browsertest.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/browser_options_handler.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 6 chunks +11 lines, -11 lines 0 comments Download
A + chrome/browser/ui/webui/options/certificate_manager_browsertest.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/certificate_manager_handler.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/OWNERS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/accounts_options_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/bluetooth_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/display_options_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/guest_mode_options_ui_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/internet_options_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/keyboard_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/language_chewing_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/language_chewing_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/language_hangul_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/language_mozc_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/language_mozc_handler.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/language_options_util.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/language_options_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/language_pinyin_handler.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/pointer_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/pointer_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/proxy_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/proxy_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/set_wallpaper_options_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/set_wallpaper_options_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/stats_options_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/stats_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/timezone_options_util.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/timezone_options_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/user_image_source.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/wallpaper_source.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/wallpaper_source.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/wallpaper_thumbnail_source.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options/chromeos/wallpaper_thumbnail_source.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/clear_browser_data_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/content_options_browsertest.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/content_settings_exception_area_browsertest.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/content_settings_handler.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/cookies_view_browsertest.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/cookies_view_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/cookies_view_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/core_options_handler.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/core_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/font_settings_browsertest.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/font_settings_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/font_settings_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/options/font_settings_utils.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options/font_settings_utils_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/font_settings_utils_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/font_settings_utils_x11.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/handler_options_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/handler_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/home_page_overlay_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/home_page_overlay_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/options/import_data_handler.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/import_data_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/language_options_browsertest.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/language_options_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/language_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/language_options_handler_common.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/language_options_handler_common.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/language_options_handler_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/options/manage_profile_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/manage_profile_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/media_galleries_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/media_galleries_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/options_browsertest.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/options_sync_setup_handler.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options/options_sync_setup_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/options_ui.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options/options_ui.cc View 1 2 3 3 chunks +38 lines, -38 lines 0 comments Download
A + chrome/browser/ui/webui/options/options_ui_browsertest.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options/options_ui_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/password_manager_browsertest.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/password_manager_handler.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/password_manager_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/preferences_browsertest.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/options/preferences_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/search_engine_manager_browsertest.js View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/webui/options/search_engine_manager_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/search_engine_manager_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/webui/options/startup_pages_handler.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/startup_pages_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/webui/options/web_intents_settings_handler.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/webui/options/web_intents_settings_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/webui/options2/OWNERS View 1 3 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/ui/webui/options2/advanced_options_utils.h View 1 3 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/ui/webui/options2/advanced_options_utils_mac.mm View 1 3 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/webui/options2/advanced_options_utils_win.cc View 1 3 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/ui/webui/options2/advanced_options_utils_x11.cc View 1 3 1 chunk +0 lines, -159 lines 0 comments Download
D chrome/browser/ui/webui/options2/autofill_options_browsertest.js View 1 3 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options2/autofill_options_handler.h View 1 3 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/ui/webui/options2/autofill_options_handler.cc View 1 3 1 chunk +0 lines, -629 lines 0 comments Download
D chrome/browser/ui/webui/options2/browser_options_browsertest.js View 1 3 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/ui/webui/options2/browser_options_handler.h View 1 3 1 chunk +0 lines, -326 lines 0 comments Download
D chrome/browser/ui/webui/options2/browser_options_handler.cc View 1 3 1 chunk +0 lines, -1442 lines 0 comments Download
D chrome/browser/ui/webui/options2/certificate_manager_browsertest.js View 1 3 1 chunk +0 lines, -202 lines 0 comments Download
D chrome/browser/ui/webui/options2/certificate_manager_handler.h View 1 3 1 chunk +0 lines, -188 lines 0 comments Download
D chrome/browser/ui/webui/options2/certificate_manager_handler.cc View 1 3 1 chunk +0 lines, -1094 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/OWNERS View 1 3 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/accounts_options_handler.h View 1 3 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/accounts_options_handler.cc View 1 3 1 chunk +0 lines, -139 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler.h View 1 3 1 chunk +0 lines, -198 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/bluetooth_options_handler.cc View 1 3 1 chunk +0 lines, -428 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler.h View 1 3 1 chunk +0 lines, -136 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler.cc View 1 3 1 chunk +0 lines, -450 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler.h View 1 3 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/core_chromeos_options_handler.cc View 1 3 1 chunk +0 lines, -254 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler.h View 1 3 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler.cc View 1 3 1 chunk +0 lines, -246 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/display_options_handler.h View 1 3 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/display_options_handler.cc View 1 3 1 chunk +0 lines, -196 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/guest_mode_options_ui_browsertest.cc View 1 3 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/internet_options_handler.h View 1 3 1 chunk +0 lines, -193 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/internet_options_handler.cc View 1 3 1 chunk +0 lines, -1760 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/keyboard_handler.h View 1 3 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/keyboard_handler.cc View 1 3 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/language_chewing_handler.h View 1 3 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/language_chewing_handler.cc View 1 3 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/language_hangul_handler.h View 1 3 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/language_hangul_handler.cc View 1 3 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/language_mozc_handler.h View 1 3 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/language_mozc_handler.cc View 1 3 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/language_options_util.h View 1 3 1 chunk +0 lines, -84 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/language_options_util.cc View 1 3 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/language_pinyin_handler.h View 1 3 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/language_pinyin_handler.cc View 1 3 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/pointer_handler.h View 1 3 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/pointer_handler.cc View 1 3 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/proxy_handler.h View 1 3 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/proxy_handler.cc View 1 3 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.h View 1 3 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/set_wallpaper_options_handler.cc View 1 3 1 chunk +0 lines, -265 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/stats_options_handler.h View 1 3 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/stats_options_handler.cc View 1 3 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/timezone_options_util.h View 1 3 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/timezone_options_util.cc View 1 3 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/user_image_source.h View 1 3 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/user_image_source.cc View 1 3 1 chunk +0 lines, -114 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/wallpaper_source.h View 1 3 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/wallpaper_source.cc View 1 3 1 chunk +0 lines, -187 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/wallpaper_thumbnail_source.h View 1 3 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/wallpaper_thumbnail_source.cc View 1 3 1 chunk +0 lines, -261 lines 0 comments Download
D chrome/browser/ui/webui/options2/clear_browser_data_handler.h View 1 3 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/webui/options2/clear_browser_data_handler.cc View 1 3 1 chunk +0 lines, -161 lines 0 comments Download
D chrome/browser/ui/webui/options2/content_options_browsertest.js View 1 3 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options2/content_settings_exception_area_browsertest.js View 1 3 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/ui/webui/options2/content_settings_handler.h View 1 3 1 chunk +0 lines, -186 lines 0 comments Download
D chrome/browser/ui/webui/options2/content_settings_handler.cc View 1 3 1 chunk +0 lines, -1341 lines 0 comments Download
D chrome/browser/ui/webui/options2/cookies_view_browsertest.js View 1 3 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options2/cookies_view_handler.h View 1 3 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/ui/webui/options2/cookies_view_handler.cc View 1 3 1 chunk +0 lines, -324 lines 0 comments Download
D chrome/browser/ui/webui/options2/core_options_handler.h View 1 3 1 chunk +0 lines, -159 lines 0 comments Download
D chrome/browser/ui/webui/options2/core_options_handler.cc View 1 3 1 chunk +0 lines, -483 lines 0 comments Download
D chrome/browser/ui/webui/options2/font_settings_browsertest.js View 1 3 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options2/font_settings_handler.h View 1 3 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/ui/webui/options2/font_settings_handler.cc View 1 3 1 chunk +0 lines, -248 lines 0 comments Download
D chrome/browser/ui/webui/options2/font_settings_utils.h View 1 3 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/ui/webui/options2/font_settings_utils_mac.mm View 1 3 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/ui/webui/options2/font_settings_utils_win.cc View 1 3 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/ui/webui/options2/font_settings_utils_x11.cc View 1 3 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/ui/webui/options2/handler_options_handler.h View 1 3 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/ui/webui/options2/handler_options_handler.cc View 1 3 1 chunk +0 lines, -208 lines 0 comments Download
D chrome/browser/ui/webui/options2/home_page_overlay_handler.h View 1 3 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/ui/webui/options2/home_page_overlay_handler.cc View 1 3 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/ui/webui/options2/import_data_handler.h View 1 3 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/ui/webui/options2/import_data_handler.cc View 1 3 1 chunk +0 lines, -192 lines 0 comments Download
D chrome/browser/ui/webui/options2/language_options_browsertest.js View 1 3 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/webui/options2/language_options_handler.h View 1 3 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/ui/webui/options2/language_options_handler.cc View 1 3 1 chunk +0 lines, -132 lines 0 comments Download
D chrome/browser/ui/webui/options2/language_options_handler_common.h View 1 3 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/ui/webui/options2/language_options_handler_common.cc View 1 3 1 chunk +0 lines, -169 lines 0 comments Download
D chrome/browser/ui/webui/options2/language_options_handler_unittest.cc View 1 3 1 chunk +0 lines, -226 lines 0 comments Download
D chrome/browser/ui/webui/options2/manage_profile_handler.h View 1 3 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/ui/webui/options2/manage_profile_handler.cc View 1 3 1 chunk +0 lines, -290 lines 0 comments Download
D chrome/browser/ui/webui/options2/media_galleries_handler.h View 1 3 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/ui/webui/options2/media_galleries_handler.cc View 1 3 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/browser/ui/webui/options2/options_browsertest.js View 1 3 1 chunk +0 lines, -106 lines 0 comments Download
D chrome/browser/ui/webui/options2/options_sync_setup_handler.h View 1 3 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/ui/webui/options2/options_sync_setup_handler.cc View 1 2 3 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/ui/webui/options2/options_ui.h View 1 3 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/ui/webui/options2/options_ui.cc View 1 3 1 chunk +0 lines, -396 lines 0 comments Download
D chrome/browser/ui/webui/options2/options_ui_browsertest.h View 1 2 3 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/ui/webui/options2/options_ui_browsertest.cc View 1 3 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/ui/webui/options2/password_manager_browsertest.js View 1 3 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/ui/webui/options2/password_manager_handler.h View 1 3 1 chunk +0 lines, -139 lines 0 comments Download
D chrome/browser/ui/webui/options2/password_manager_handler.cc View 1 3 1 chunk +0 lines, -282 lines 0 comments Download
D chrome/browser/ui/webui/options2/preferences_browsertest.h View 1 3 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/ui/webui/options2/preferences_browsertest.cc View 1 3 1 chunk +0 lines, -412 lines 0 comments Download
D chrome/browser/ui/webui/options2/search_engine_manager_browsertest.js View 1 3 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/ui/webui/options2/search_engine_manager_handler.h View 1 3 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/ui/webui/options2/search_engine_manager_handler.cc View 1 3 1 chunk +0 lines, -317 lines 0 comments Download
D chrome/browser/ui/webui/options2/startup_pages_handler.h View 1 3 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/browser/ui/webui/options2/startup_pages_handler.cc View 1 3 1 chunk +0 lines, -259 lines 0 comments Download
D chrome/browser/ui/webui/options2/web_intents_settings_handler.h View 1 3 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/ui/webui/options2/web_intents_settings_handler.cc View 1 3 1 chunk +0 lines, -164 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler.h View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 1 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 3 4 chunks +96 lines, -96 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 3 5 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Hawkins
8 years, 4 months ago (2012-08-18 14:55:45 UTC) #1
csilv
8 years, 4 months ago (2012-08-18 20:07:38 UTC) #2 
lgtm

recommend re-base and green trybots before submit.  :-)

http://codereview.chromium.org/10837331/diff/1/chrome/browser/ui/webui/option...
File chrome/browser/ui/webui/options/options_ui.cc (right):

http://codereview.chromium.org/10837331/diff/1/chrome/browser/ui/webui/option...
chrome/browser/ui/webui/options/options_ui.cc:155:
LoadDataResourceBytes(IDR_OPTIONS_HTML, ui::SCALE_FACTOR_NONE);
I will assume that because of these changes and line 57, your resources/options
CL will need to go in first.

Powered by Google App Engine
This is Rietveld 408576698