Add a completion callback to gpuBenchmarking.beginSmoothScroll

Add a completion callback to gpuBenchmarking.beginSmoothScroll

R=piman@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152255

[piman, 2012-08-18 06:36:58]

LGTM+nit

http://codereview.chromium.org/10837330/diff/1009/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_base.cc (right):

http://codereview.chromium.org/10837330/diff/1009/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_base.cc:161:
~BasicMouseWheelSmoothScrollGesture() { }
nit: virtual

http://codereview.chromium.org/10837330/diff/1009/content/renderer/render_wid...
File content/renderer/render_widget.cc (right):

http://codereview.chromium.org/10837330/diff/1009/content/renderer/render_wid...
content/renderer/render_widget.cc:1817:
pending_smooth_scroll_gestures_.insert(std::make_pair(id, callback));
Just curious because I'm not familiar with the code. Does anything need to
happen to these callbacks in case of navigation or this sort of things? Does it
reset/destroy v8 contexts?

[nduca, 2012-08-18 07:17:18]

> pending_smooth_scroll_gestures_.insert(std::make_pair(id, callback));
> Just curious because I'm not familiar with the code. Does anything need to
> happen to these callbacks in case of navigation or this sort of things? Does
it
> reset/destroy v8 contexts?

Good question. As I understand it, the v8::Persistent<T> type is basically like
a raw pointer -- you can copy Persistent to Persistent. The actual call Destroy
is what actually frees them up.

As currently written, in the case of navigation, I think we'd in-fact leak. Its
probably not an issue in benchmarks, but its clearly not good for heavy-duty
use. I'll add a TODO note that points this limitation out.

[commit-bot: I haz the power, 2012-08-18 07:27:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nduca@chromium.org/10837330/3002

[commit-bot: I haz the power, 2012-08-18 09:06:31]

Change committed as 152255