Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 10837325: Make each NaCl glibc test copy its shared libraries into a unique directory. (Closed)

Created:
8 years, 4 months ago by Nick Bray (chromium)
Modified:
8 years, 4 months ago
Reviewers:
bradnelson
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Make each NaCl glibc test copy its shared libraries into a unique directory. This will prevent build problems when there is more than one glibc test. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2959 TEST= none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/test/data/nacl/nacl_browser_test.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/tools/create_nmf.py View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nick Bray (chromium)
8 years, 4 months ago (2012-08-18 00:39:19 UTC) #1
bradnelson
lgtm
8 years, 4 months ago (2012-08-18 00:52:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ncbray@chromium.org/10837325/1
8 years, 4 months ago (2012-08-20 16:56:48 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 22:15:03 UTC) #4
Change committed as 152401

Powered by Google App Engine
This is Rietveld 408576698