Issue 10837320: Add flag to allow deletion of printers when enumerate fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837320: Add flag to allow deletion of printers when enumerate fails. (Closed)

Created:
8 years, 4 months ago by Albert Bodenhamer

Modified:
8 years, 4 months ago

Reviewers:
gene

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add flag to allow deletion of printers when enumerate fails. If enumerating printers fails, any printers we have registered but which aren't enumerated look online, but are unable to process jobs. This CL adds cloud_print.print_system_settings.delete_on_enum_fail to the service state file. If it is set to true any printers that don't enumerate will be deleted. This is preferable in some situations where sharing and remembering history for a printer is less important than preventing it from being incorrectly shown. BUG=142337 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152223

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -2 lines)			Patch
	M	chrome/service/cloud_print/cloud_print_connector.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/service/cloud_print/cloud_print_connector.cc	View	1 2	4 chunks	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/10837320/3003

8 years, 4 months ago (2012-08-17 22:41:10 UTC) #4

Change committed as 152223

Expand Messages | Collapse Messages

Issue 10837320: Add flag to allow deletion of printers when enumerate fails. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix type #

Patch Set 3 : Review feedback #

Messages