Issue 10837316: Add full ARM syscall list.

Issue 10837316: Add full ARM syscall list. (Closed)

Created:
8 years, 4 months ago by Jorge Lucangeli Obes

Modified:
8 years, 4 months ago

Reviewers:
jln (very slow on Chromium), Chris Evans

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, agl, jln+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@seccomp-bpf-arm-sets

Visibility:
Public.

More Reviews

Description

Add full ARM syscall list. BUG=141157 TEST=Build and boot on daisy, check about:sandbox for "Seccomp-BPF Yes". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152448

Patch Set 2 : Rebase over latest seccomp-bpf ARM CL #

Patch Set 4 : Add ARM EABI define guards. #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1363 lines, -41 lines)			Patch
M	content/common/sandbox_seccomp_bpf_linux.cc	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	sandbox/linux/services/arm_linux_syscalls.h	View	1 2 3	1 chunk	+1355 lines, -10 lines	2 comments	Download
A +	sandbox/linux/services/linux_syscalls.h	View	1 2 3	2 chunks	+7 lines, -3 lines	0 comments	Download
D	sandbox/linux/services/x86_linux_syscalls.h	View		1 chunk	+0 lines, -21 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

jln (very slow on Chromium)

Things are getting tidy, I like it! https://chromiumcodereview.appspot.com/10837316/diff/4005/sandbox/linux/services/arm_linux_syscalls.h File sandbox/linux/services/arm_linux_syscalls.h (right): https://chromiumcodereview.appspot.com/10837316/diff/4005/sandbox/linux/services/arm_linux_syscalls.h#newcode9 sandbox/linux/services/arm_linux_syscalls.h:9: #if !defined(__arm__) ...

8 years, 4 months ago (2012-08-20 18:21:50 UTC) #2

Jorge Lucangeli Obes

https://chromiumcodereview.appspot.com/10837316/diff/4005/sandbox/linux/services/arm_linux_syscalls.h File sandbox/linux/services/arm_linux_syscalls.h (right): https://chromiumcodereview.appspot.com/10837316/diff/4005/sandbox/linux/services/arm_linux_syscalls.h#newcode9 sandbox/linux/services/arm_linux_syscalls.h:9: #if !defined(__arm__) On 2012/08/20 18:21:51, Julien Tinnes wrote: > ...

8 years, 4 months ago (2012-08-20 18:59:06 UTC) #3

jln (very slow on Chromium)

https://chromiumcodereview.appspot.com/10837316/diff/4007/sandbox/linux/services/arm_linux_syscalls.h File sandbox/linux/services/arm_linux_syscalls.h (right): https://chromiumcodereview.appspot.com/10837316/diff/4007/sandbox/linux/services/arm_linux_syscalls.h#newcode9 sandbox/linux/services/arm_linux_syscalls.h:9: #if !defined(__arm__) || !defined(__ARM_EABI__) &&, not || :)

8 years, 4 months ago (2012-08-20 19:21:59 UTC) #4

Jorge Lucangeli Obes

8 years, 4 months ago (2012-08-20 19:29:22 UTC) #5

jln (very slow on Chromium)

On 2012/08/20 19:29:22, Jorge Lucangeli Obes wrote: > https://chromiumcodereview.appspot.com/10837316/diff/4007/sandbox/linux/services/arm_linux_syscalls.h > File sandbox/linux/services/arm_linux_syscalls.h (right): > > ...

8 years, 4 months ago (2012-08-20 19:30:46 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/10837316/4007

8 years, 4 months ago (2012-08-20 20:04:38 UTC) #7

commit-bot: I haz the power

Try job failure for 10837316-4007 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...

8 years, 4 months ago (2012-08-20 21:40:11 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/10837316/4007

8 years, 4 months ago (2012-08-20 22:04:30 UTC) #9

Change committed as 152448

Expand Messages | Collapse Messages