Make stackmaps store their actual length.

runtime/vm/code_descriptors.h

Index: runtime/vm/code_descriptors.h
diff --git a/runtime/vm/code_descriptors.h b/runtime/vm/code_descriptors.h
index 0d8e8381a6e67dc7c296ae939b3173267e9e7977..21474d7559c7d0aa499c8cb3e5604914cf5a55dd 100644
--- a/runtime/vm/code_descriptors.h
+++ b/runtime/vm/code_descriptors.h
@@ -65,8 +65,8 @@ class DescriptorList : public ZoneAllocated {
 
 class StackmapTableBuilder : public ZoneAllocated {
  public:
-  explicit StackmapTableBuilder(intptr_t entry_length_in_bits)
-      : entry_length_in_bits_(entry_length_in_bits),
+  explicit StackmapTableBuilder(intptr_t entry_length)
+      : entry_length_(entry_length),
         stack_map_(Stackmap::ZoneHandle()),
         list_(GrowableObjectArray::ZoneHandle(
             GrowableObjectArray::New(Heap::kOld))) { }
@@ -83,7 +83,7 @@ class StackmapTableBuilder : public ZoneAllocated {
   RawStackmap* MapAt(int index) const;
 
   // All the stackmaps in a function have the same length.
-  intptr_t entry_length_in_bits_;
+  const intptr_t entry_length_;

[srdjan, 2012/08/21 16:06:04]

Why did you remove the _in_bits?  I assume it is now in bytes

[Kevin Millikin (Google), 2012/08/22 07:34:18]

No, it's the number of entries in each stackmap.  Internally, there is one bit
per entry but that is an implementation detail.  I got rid of the _in_bits part
because I don't think it matters.

I'm happy to see the name change if there are better alternatives (note that
this field is already eliminated in a change that I have out for review).

   Stackmap& stack_map_;
   GrowableObjectArray& list_;
   DISALLOW_COPY_AND_ASSIGN(StackmapTableBuilder);