Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm

Issue 10837296: Fix a bug where the inspector would not keep event pages alive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: yurys Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
index 158155d48f010b8fad24e84a0aae2228d8cc5926..a405101fdee26c7125ad5691b16c8871ebb8ee91 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller.mm
@@ -93,7 +93,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {
}
break;
}
- case content::NOTIFICATION_DEVTOOLS_WINDOW_OPENING: {
+ case content::NOTIFICATION_DEVTOOLS_AGENT_ATTACHED: {
RenderViewHost* rvh = [controller_ extensionHost]->render_view_host();
if (content::Details<RenderViewHost>(rvh) == details)
// Set the flag on the controller so the popup is not hidden when
@@ -101,7 +101,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {
[controller_ setBeingInspected:YES];
break;
}
- case content::NOTIFICATION_DEVTOOLS_WINDOW_CLOSING: {
+ case content::NOTIFICATION_DEVTOOLS_AGENT_DETACHED: {
RenderViewHost* rvh = [controller_ extensionHost]->render_view_host();
if (content::Details<RenderViewHost>(rvh) == details)
// Allow the devtools to finish detaching before we close the popup
@@ -164,7 +164,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {
// Listen for the the devtools window closing so we can close this window if
// it is being inspected and the inspector is closed.
registrar_->Add(notificationBridge_.get(),
- content::NOTIFICATION_DEVTOOLS_WINDOW_CLOSING,
+ content::NOTIFICATION_DEVTOOLS_AGENT_DETACHED,
content::Source<content::BrowserContext>(
host->profile()));
if (beingInspected_) {
@@ -177,7 +177,7 @@ class DevtoolsNotificationBridge : public content::NotificationObserver {
// Listen for the dev tools opening on this popup, so we can stop it going
// away when the dev tools get focus.
registrar_->Add(notificationBridge_.get(),
- content::NOTIFICATION_DEVTOOLS_WINDOW_OPENING,
+ content::NOTIFICATION_DEVTOOLS_AGENT_ATTACHED,
content::Source<content::BrowserContext>(
host->profile()));
}
« no previous file with comments | « chrome/browser/extensions/extension_process_manager.cc ('k') | chrome/browser/ui/gtk/extensions/extension_popup_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698