Issue 10837292: [Chromoting] Moving the I/O thread out of DaemonProcess (so it can be shared if needed).

Issue 10837292: [Chromoting] Moving the I/O thread out of DaemonProcess (so it can be shared if needed). (Closed)

Created:
8 years, 4 months ago by alexeypa (please no reviews)

Modified:
8 years, 4 months ago

Reviewers:
simonmorris

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Chromoting] Moving the I/O thread out of DaemonProcess (so it can be shared if needed). BUG=134694 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152299

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -27 lines)			Patch
M	remoting/host/daemon_process.h	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	remoting/host/daemon_process.cc	View		3 chunks	+3 lines, -14 lines	0 comments	Download
M	remoting/host/daemon_process_win.cc	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	remoting/host/win/host_service.cc	View		2 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

simonmorris

lgtm http://codereview.chromium.org/10837292/diff/1/remoting/host/daemon_process.h File remoting/host/daemon_process.h (right): http://codereview.chromium.org/10837292/diff/1/remoting/host/daemon_process.h#newcode61 remoting/host/daemon_process.h:61: // Handles IPC and bacjground I/O tasks. "background"

8 years, 4 months ago (2012-08-16 22:34:39 UTC) #2

alexeypa (please no reviews)

http://codereview.chromium.org/10837292/diff/1/remoting/host/daemon_process.h File remoting/host/daemon_process.h (right): http://codereview.chromium.org/10837292/diff/1/remoting/host/daemon_process.h#newcode61 remoting/host/daemon_process.h:61: // Handles IPC and bacjground I/O tasks. On 2012/08/16 ...

8 years, 4 months ago (2012-08-18 00:23:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10837292/9001

8 years, 4 months ago (2012-08-19 17:47:18 UTC) #4

Change committed as 152299

Expand Messages | Collapse Messages