Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: runtime/vm/parser.cc

Issue 10837288: New getter syntax for top-level getters (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc (revision 10826)
+++ runtime/vm/parser.cc (working copy)
@@ -3766,13 +3766,13 @@
const intptr_t name_pos = TokenPos();
const String* field_name = ExpectIdentifier("accessor name expected");
- if (CurrentToken() != Token::kLPAREN) {
- ErrorMsg("'(' expected");
- }
const intptr_t accessor_pos = TokenPos();
ParamList params;
- const bool allow_explicit_default_values = true;
- ParseFormalParameterList(allow_explicit_default_values, &params);
+ // TODO(hausner): Remove the ( check once we remove old getter syntax.
+ if (!is_getter || (CurrentToken() == Token::kLPAREN)) {
+ const bool allow_explicit_default_values = true;
+ ParseFormalParameterList(allow_explicit_default_values, &params);
+ }
String& accessor_name = String::ZoneHandle();
int expected_num_parameters = -1;
if (is_getter) {
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698