Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2568)

Unified Diff: chrome/common/extensions/features/feature.cc

Issue 10837275: Log the channel that we're on when failing due to unsupported features, to aid in debugging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/features/feature.cc
diff --git a/chrome/common/extensions/features/feature.cc b/chrome/common/extensions/features/feature.cc
index 3da8726e386acf3003ece3a22741e6612cb42836..275c807aabd39fe6b75e85b114387e3e9637cf04 100644
--- a/chrome/common/extensions/features/feature.cc
+++ b/chrome/common/extensions/features/feature.cc
@@ -246,9 +246,11 @@ std::string Feature::GetErrorMessage(Feature::Availability result) {
name().c_str());
case UNSUPPORTED_CHANNEL:
return base::StringPrintf(
- "'%s' requires Google Chrome %s channel or newer.",
+ "'%s' requires Google Chrome %s channel or newer, and we're running "
+ "on the %s channel.",
name().c_str(),
- GetChannelName(channel_).c_str());
+ GetChannelName(channel_).c_str(),
+ GetChannelName(GetCurrentChannel()).c_str());
}
return "";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698