Issue 10837270: webui: Change slightly how the scale-factor gets parsed from a URL.

Issue 10837270: webui: Change slightly how the scale-factor gets parsed from a URL. (Closed)

Created:
8 years, 4 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:
flackr, Ben Goodger (Google), Ivan Korotkov, Evan Stade

CC:
chromium-reviews, Ivan Korotkov

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

webui: Change slightly how the scale-factor gets parsed from a URL. Some of the URLs can include both the scale factor and user email. However, either/both may be missing at times. So make sure the path and scale-factor are parsed correctly from the URL in these cases. BUG=141146 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151936

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : indent #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -29 lines)			Patch
M	chrome/browser/ui/webui/fileicon_source.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/user_image_source.cc	View	1 2	1 chunk	+1 line, -15 lines	0 comments	Download
M	chrome/browser/ui/webui/web_ui_util.h	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/web_ui_util.cc	View	1 2 3	2 chunks	+17 lines, -10 lines	0 comments	Download
A	chrome/browser/ui/webui/web_ui_util_unittest.cc	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Ivan Korotkov

Could you please also fix https://cs.corp.google.com/#chrome/src/chrome/browser/ui/webui/options2/chromeos/user_image_source.cc&l=38 ? Right now it parses username@domain separately instead of ...

8 years, 4 months ago (2012-08-16 08:53:51 UTC) #2

sadrul

On 2012/08/16 08:53:51, Ivan Korotkov wrote: > Could you please also fix > https://cs.corp.google.com/#chrome/src/chrome/browser/ui/webui/options2/chromeos/user_image_source.cc&l=38 > ...

8 years, 4 months ago (2012-08-16 15:35:16 UTC) #3

Evan Stade

webui lgtm http://codereview.chromium.org/10837270/diff/9001/chrome/browser/ui/webui/web_ui_util.cc File chrome/browser/ui/webui/web_ui_util.cc (right): http://codereview.chromium.org/10837270/diff/9001/chrome/browser/ui/webui/web_ui_util.cc#newcode110 chrome/browser/ui/webui/web_ui_util.cc:110: pos + 1, stripped_path.length() - pos - ...

8 years, 4 months ago (2012-08-16 18:57:49 UTC) #8

sadrul

8 years, 4 months ago (2012-08-16 19:00:33 UTC) #9

http://codereview.chromium.org/10837270/diff/9001/chrome/browser/ui/webui/web...
File chrome/browser/ui/webui/web_ui_util.cc (right):

http://codereview.chromium.org/10837270/diff/9001/chrome/browser/ui/webui/web...
chrome/browser/ui/webui/web_ui_util.cc:110: pos + 1, stripped_path.length() -
pos - 1), &factor)) {
On 2012/08/16 18:57:49, Evan Stade wrote:
> 2 more indent

Done.

Expand Messages | Collapse Messages