chromeos: Improve version label on login screen.

chromeos: Improve version label on login screen.

This changes the color of the version label on the login
screen (shown only for dev builds, I believe) so it uses
light text with a dark outline instead of light-gray text
with a white shadow, which just looks blurry to me.

BUG=139360
TEST=version text is more readable with light and dark backgrounds

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152382

[nkostylev (pls use chromium), 2012-08-15 17:26:55]

Thanks for working on this polishing bug!

Please reference this bug and it also has updated spec to use
http://code.google.com/p/chromium/issues/detail?id=139360
15.08.2012 19:56 пользователь <derat@chromium.org> написал:

> Reviewers: DaveMoore,
>
> Description:
> chromeos: Improve version label on login screen.
>
> This changes the color of the version label on the login
> screen (shown only for dev builds, I believe) so it uses
> light text with a dark shadow instead of light-gray text
> with a white shadow, which just looks blurry to me.
>
> BUG=none
> TEST=version text is more readable with light and dark backgrounds
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10837263/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/resources/**chromeos/login/oobe.css
>
>
> Index: chrome/browser/resources/**chromeos/login/oobe.css
> diff --git a/chrome/browser/resources/**chromeos/login/oobe.css
> b/chrome/browser/resources/**chromeos/login/oobe.css
> index e02cf863de702b544de750bf8f8340**adbb36369e..**
> 7c3dbe2c449138fe60ee81e3b5813a**f71280fb5a 100644
> --- a/chrome/browser/resources/**chromeos/login/oobe.css
> +++ b/chrome/browser/resources/**chromeos/login/oobe.css
> @@ -1282,12 +1282,12 @@ html[dir=rtl] .error-message {
>
>  #version-labels {
>    -webkit-transition: all 500ms linear;
> -  color: #999;
> +  color: #fff;
>    font-size: 11px;
>    margin: 10px;
> -  opacity: 1.0;
> +  opacity: 0.75;
>    text-align: end;
> -  text-shadow: 0 1px 1px #fff;
> +  text-shadow: 0 1px 1px #000;
>  }
>
>  #offline-network-control {
>
>
>

[Daniel Erat, 2012-08-15 22:18:17]

Updated to match Ken's spec.

http://codereview.chromium.org/10837263/diff/1002/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe.css (right):

http://codereview.chromium.org/10837263/diff/1002/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe.css:1289: text-shadow: 0 0 4px
rgba(0,0,0,.6), 0 1px 2px rgba(0,0,0,.8), 0 -1px 2px rgba(0,0,0,1);
couldn't find anything about line length for css files...

[Daniel Erat, 2012-08-17 14:21:00]

Scott, everyone I add as a reviewer seems to suspiciously go OOO soon
afterwards.  Mind taking a look?

[sky, 2012-08-20 14:58:59]

LGTM

[commit-bot: I haz the power, 2012-08-20 15:00:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10837263/1002

[commit-bot: I haz the power, 2012-08-20 15:01:02]

Presubmit check for 10837263-1002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  chrome/browser/resources/chromeos/login/oobe.css, line 1290, 90 chars

Presubmit checks took 1.3s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2012-08-20 16:55:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10837263/10001

[commit-bot: I haz the power, 2012-08-20 20:31:15]

Change committed as 152382