Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 10837263: chromeos: Improve version label on login screen. (Closed)

Created:
8 years, 4 months ago by Daniel Erat
Modified:
8 years, 4 months ago
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

chromeos: Improve version label on login screen. This changes the color of the version label on the login screen (shown only for dev builds, I believe) so it uses light text with a dark outline instead of light-gray text with a white shadow, which just looks blurry to me. BUG=139360 TEST=version text is more readable with light and dark backgrounds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152382

Patch Set 1 #

Patch Set 2 : update to match spec #

Total comments: 1

Patch Set 3 : wrap long line; merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/login/oobe.css View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Daniel Erat
8 years, 4 months ago (2012-08-15 16:56:40 UTC) #1
nkostylev (pls use chromium)
Thanks for working on this polishing bug! Please reference this bug and it also has ...
8 years, 4 months ago (2012-08-15 17:26:55 UTC) #2
Daniel Erat
Updated to match Ken's spec. http://codereview.chromium.org/10837263/diff/1002/chrome/browser/resources/chromeos/login/oobe.css File chrome/browser/resources/chromeos/login/oobe.css (right): http://codereview.chromium.org/10837263/diff/1002/chrome/browser/resources/chromeos/login/oobe.css#newcode1289 chrome/browser/resources/chromeos/login/oobe.css:1289: text-shadow: 0 0 4px ...
8 years, 4 months ago (2012-08-15 22:18:17 UTC) #3
Daniel Erat
Scott, everyone I add as a reviewer seems to suspiciously go OOO soon afterwards. Mind ...
8 years, 4 months ago (2012-08-17 14:21:00 UTC) #4
sky
LGTM
8 years, 4 months ago (2012-08-20 14:58:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10837263/1002
8 years, 4 months ago (2012-08-20 15:00:58 UTC) #6
commit-bot: I haz the power
Presubmit check for 10837263-1002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-20 15:01:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10837263/10001
8 years, 4 months ago (2012-08-20 16:55:49 UTC) #8
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 20:31:15 UTC) #9
Change committed as 152382

Powered by Google App Engine
This is Rietveld 408576698