Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 10837255: Clarifying the CSP restrictions with regard to `connect-src` and `unsafe-eval`. (Closed)

Created:
8 years, 4 months ago by Mike West
Modified:
8 years, 4 months ago
CC:
chromium-reviews, ernestd1
Visibility:
Public.

Description

Clarifying the CSP restrictions with regard to `connect-src` and `unsafe-eval`. BUG=115482 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -6 lines) Patch
M chrome/common/extensions/docs/extensions/contentSecurityPolicy.html View 3 chunks +14 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/templates/articles/contentSecurityPolicy.html View 3 chunks +15 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/static/contentSecurityPolicy.html View 3 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike West
Hi all, this is a pass at clarifying the CSP restrictions. WDYT?
8 years, 4 months ago (2012-08-15 10:09:04 UTC) #1
mkearney
lgtm The added note makes it a good bit clearer.
8 years, 4 months ago (2012-08-15 14:52:03 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-08-16 07:13:47 UTC) #3
Mihai Parparita -not on Chrome
LGTM
8 years, 4 months ago (2012-08-16 18:15:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/10837255/1
8 years, 4 months ago (2012-08-16 18:16:15 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-16 20:58:47 UTC) #6
Change committed as 151961

Powered by Google App Engine
This is Rietveld 408576698