Issue 10837250: gdata: Make callback parameter mandatory for GetEntryInfoByPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837250: gdata: Make callback parameter mandatory for GetEntryInfoByPath() (Closed)

Created:
8 years, 4 months ago by satorux1

Modified:
8 years, 4 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Make callback parameter mandatory for GetEntryInfoByPath() Forgot to do this in crrev.com/151558... BUG=126634 TEST=out/Release/unit_tests --gtest_filter=GData* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151579

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		3 chunks	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

achuithb

lgtm. It will be a good day when all callbacks can be made mandatory. I ...

8 years, 4 months ago (2012-08-14 21:57:27 UTC) #2

satorux1

8 years, 4 months ago (2012-08-14 22:00:58 UTC) #3

On 2012/08/14 21:57:27, achuith.bhandarkar wrote:
> lgtm.
> 
> It will be a good day when all callbacks can be made mandatory. I think we're
> close?

More than half is done.

Two weeks ago, there were 64 instances of if (!callback.is_null())
http://git.chromium.org/gitweb/?p=chromium.git;a=blob;f=chrome/browser/chrome...

With this change, there are 30 instances.

Expand Messages | Collapse Messages