use bit fields for class state and field type values. This shrinks the snapshot

vm/raw_object.h

Index: vm/raw_object.h
===================================================================
--- vm/raw_object.h	(revision 10677)
+++ vm/raw_object.h	(working copy)
@@ -407,9 +407,7 @@
   intptr_t next_field_offset_;  // Offset of the next instance field.
   intptr_t num_native_fields_;  // Number of native fields in class.
   intptr_t token_pos_;
-  int8_t class_state_;  // Of type ClassState.
-  bool is_const_;
-  bool is_interface_;
+  uint8_t state_bits_;  // state, is_const, is_interface.

[cshapiro, 2012/08/14 22:05:13]

Any reason not to make this and the related field on line 612 an intptr_t
instead of a uint8_t?  There is no space savings at runtime because of
allocation alignment.

[siva, 2012/08/14 22:40:18]

True, but it documents the size requirement of these fields more clearly. I want
to avoid the scenario where somebody adds a int8 or int16 field without
realizing that this field only needed to be 8 bits long.


On 2012/08/14 22:05:13, cshapiro wrote:

 
   friend class Object;
   friend class RawInstance;
@@ -611,10 +609,7 @@
   RawObject** to() { return reinterpret_cast<RawObject**>(&ptr()->value_); }
 
   intptr_t token_pos_;
-  bool is_static_;
-  bool is_final_;
-  bool is_const_;
-  bool has_initializer_;
+  uint8_t kind_bits_;  // static, final, const, has initializer.
 };