Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10837246: Skipping few failing tests from gpu_tests, performance_ui_tests and sync_integration_tests on cover… (Closed)

Created:
8 years, 4 months ago by pshenoy
Modified:
8 years, 4 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, pam+watch_chromium.org, John Grabowski, anantha
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Skipping few failing tests from gpu_tests, performance_ui_tests and sync_integration_tests on coverage bot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151636

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -10 lines) Patch
M tools/code_coverage/coverage_posix.py View 1 2 3 4 1 chunk +79 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pshenoy
8 years, 4 months ago (2012-08-14 20:39:17 UTC) #1
Nirnimesh
Lines should be no longer than 80 chars.
8 years, 4 months ago (2012-08-14 20:41:01 UTC) #2
pshenoy
Done.
8 years, 4 months ago (2012-08-14 21:09:14 UTC) #3
Nirnimesh
https://chromiumcodereview.appspot.com/10837246/diff/3002/tools/code_coverage/coverage_posix.py File tools/code_coverage/coverage_posix.py (right): https://chromiumcodereview.appspot.com/10837246/diff/3002/tools/code_coverage/coverage_posix.py#newcode193 tools/code_coverage/coverage_posix.py:193: 'WebGLConformanceTests.\ This is not what you think it is. ...
8 years, 4 months ago (2012-08-14 21:11:40 UTC) #4
pshenoy
Done.
8 years, 4 months ago (2012-08-14 21:41:15 UTC) #5
Nirnimesh
https://chromiumcodereview.appspot.com/10837246/diff/9001/tools/code_coverage/coverage_posix.py File tools/code_coverage/coverage_posix.py (right): https://chromiumcodereview.appspot.com/10837246/diff/9001/tools/code_coverage/coverage_posix.py#newcode194 tools/code_coverage/coverage_posix.py:194: 'conformance_attribs_gl_disabled_vertex_attrib', indent continuation lines by 4 chars
8 years, 4 months ago (2012-08-14 22:12:13 UTC) #6
pshenoy
https://chromiumcodereview.appspot.com/10837246/diff/3002/tools/code_coverage/coverage_posix.py File tools/code_coverage/coverage_posix.py (right): https://chromiumcodereview.appspot.com/10837246/diff/3002/tools/code_coverage/coverage_posix.py#newcode193 tools/code_coverage/coverage_posix.py:193: 'WebGLConformanceTests.\ On 2012/08/14 21:11:40, Nirnimesh wrote: > This is ...
8 years, 4 months ago (2012-08-14 22:40:38 UTC) #7
Nirnimesh
LGTM https://chromiumcodereview.appspot.com/10837246/diff/10002/tools/code_coverage/coverage_posix.py File tools/code_coverage/coverage_posix.py (right): https://chromiumcodereview.appspot.com/10837246/diff/10002/tools/code_coverage/coverage_posix.py#newcode225 tools/code_coverage/coverage_posix.py:225: remove
8 years, 4 months ago (2012-08-14 23:31:56 UTC) #8
pshenoy
https://chromiumcodereview.appspot.com/10837246/diff/10002/tools/code_coverage/coverage_posix.py File tools/code_coverage/coverage_posix.py (right): https://chromiumcodereview.appspot.com/10837246/diff/10002/tools/code_coverage/coverage_posix.py#newcode225 tools/code_coverage/coverage_posix.py:225: On 2012/08/14 23:31:56, Nirnimesh wrote: > remove Done.
8 years, 4 months ago (2012-08-14 23:35:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pshenoy@chromium.org/10837246/4002
8 years, 4 months ago (2012-08-14 23:35:54 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 02:37:36 UTC) #11 
Change committed as 151636

Powered by Google App Engine
This is Rietveld 408576698