Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1625)

Unified Diff: chrome/browser/autocomplete/history_quick_provider.cc

Issue 10837244: Replace HistoryQuickProvider protobuf-based caching with an SQLite-based database. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Tweak suppression. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/history_quick_provider.cc
===================================================================
--- chrome/browser/autocomplete/history_quick_provider.cc (revision 151481)
+++ chrome/browser/autocomplete/history_quick_provider.cc (working copy)
@@ -147,8 +147,13 @@
}
}
-// TODO(mrossetti): Implement this function. (Will happen in next CL.)
-void HistoryQuickProvider::DeleteMatch(const AutocompleteMatch& match) {}
+void HistoryQuickProvider::DeleteMatch(const AutocompleteMatch& match) {
+ DCHECK(match.deletable);
+ DCHECK(match.destination_url.is_valid());
+ // Delete the match from the InMemoryURLIndex.
+ GetIndex()->DeleteURL(match.destination_url);
+ DeleteMatchFromMatches(match);
+}
HistoryQuickProvider::~HistoryQuickProvider() {}

Powered by Google App Engine
This is Rietveld 408576698