Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: sql/diagnostic_error_delegate.h

Issue 10837244: Replace HistoryQuickProvider protobuf-based caching with an SQLite-based database. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Tweak suppression. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef SQL_DIAGNOSTIC_ERROR_DELEGATE_H_ 5 #ifndef SQL_DIAGNOSTIC_ERROR_DELEGATE_H_
6 #define SQL_DIAGNOSTIC_ERROR_DELEGATE_H_ 6 #define SQL_DIAGNOSTIC_ERROR_DELEGATE_H_
7 7
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "sql/connection.h" 10 #include "sql/connection.h"
11 #include "sql/sql_export.h" 11 #include "sql/sql_export.h"
12 12
13 namespace sql { 13 namespace sql {
14 14
15 // The histogram values from sqlite result codes currently range from 1 to 26
16 // but 50 gives them room to grow.
17 static const int kMaxSqliteError = 50;
18
15 // This class handles the exceptional sqlite errors that we might encounter 19 // This class handles the exceptional sqlite errors that we might encounter
16 // if for example the db is corrupted. Right now we just generate a UMA 20 // if for example the db is corrupted. Right now we just generate a UMA
17 // histogram for release and an assert for debug builds. 21 // histogram for release and an assert for debug builds.
18 // 22 //
19 // Why is it a template you ask? well, that is a funny story. The histograms 23 // Why is it a template you ask? well, that is a funny story. The histograms
20 // need to be singletons that is why they are always static at the function 24 // need to be singletons that is why they are always static at the function
21 // scope, but we cannot use the Singleton class because they are not default 25 // scope, but we cannot use the Singleton class because they are not default
22 // constructible. The template parameter makes the compiler to create unique 26 // constructible. The template parameter makes the compiler to create unique
23 // classes that don't share the same static variable. 27 // classes that don't share the same static variable.
24 template <class UniqueT> 28 template <class UniqueT>
25 class DiagnosticErrorDelegate : public ErrorDelegate { 29 class DiagnosticErrorDelegate : public ErrorDelegate {
26 public: 30 public:
27 31
28 virtual int OnError(int error, Connection* connection, 32 virtual int OnError(int error, Connection* connection,
29 Statement* stmt) { 33 Statement* stmt) {
30 LOG(ERROR) << "sqlite error " << error 34 LOG(ERROR) << "sqlite error " << error
31 << ", errno " << connection->GetLastErrno() 35 << ", errno " << connection->GetLastErrno()
32 << ": " << connection->GetErrorMessage(); 36 << ": " << connection->GetErrorMessage();
33 RecordErrorInHistogram(error); 37 RecordErrorInHistogram(error);
34 return error; 38 return error;
35 } 39 }
36 40
37 private: 41 private:
38 static void RecordErrorInHistogram(int error) { 42 static void RecordErrorInHistogram(int error) {
39 // Trim off the extended error codes. 43 // Trim off the extended error codes.
40 error &= 0xff; 44 error &= 0xff;
41 45
42 // The histogram values from sqlite result codes go currently from 1 to 46 UMA_HISTOGRAM_ENUMERATION(UniqueT::name(), error, kMaxSqliteError);
43 // 26 currently but 50 gives them room to grow.
44 UMA_HISTOGRAM_ENUMERATION(UniqueT::name(), error, 50);
45 } 47 }
46 }; 48 };
47 49
48 } // namespace sql 50 } // namespace sql
49 51
50 #endif // SQL_DIAGNOSTIC_ERROR_DELEGATE_H_ 52 #endif // SQL_DIAGNOSTIC_ERROR_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698