Search state transitions not working

Search state transitions not working

This change codifies and fixes the state transitions used in
the Search UI.  It documents the transitions in tabular
form in search_types.h detailing the user interaction that
results in either animated or non-animated transitions.
The pending navigation signal is removed, so all transitions now
occur on the navigation "committed" signal.

BUG=133529
TEST=Manual
R=sky@chromium.org, kuan@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152047

[sky, 2012-08-14 17:45:27]

LGTM - it would be nice to have some tests at some point.

[dhollowa, 2012-08-14 17:49:56]

On 2012/08/14 17:45:27, sky wrote:
> LGTM - it would be nice to have some tests at some point.

Agreed.  Will work on that next.

[kuan, 2012-08-14 20:02:15]

lgtm, only nit.

http://codereview.chromium.org/10837240/diff/1/chrome/browser/ui/search/searc...
File chrome/browser/ui/search/search_types.h (right):

http://codereview.chromium.org/10837240/diff/1/chrome/browser/ui/search/searc...
chrome/browser/ui/search/search_types.h:27: // *** Transtions ***
nit typo: s/Transtions/Transitions/

[commit-bot: I haz the power, 2012-08-16 00:38:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10837240/7004

[commit-bot: I haz the power, 2012-08-16 01:14:16]

Try job failure for 10837240-7004 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-08-16 21:40:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10837240/14003

[commit-bot: I haz the power, 2012-08-16 22:14:53]

Try job failure for 10837240-14003 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2012-08-17 01:26:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dhollowa@chromium.org/10837240/18

[commit-bot: I haz the power, 2012-08-17 04:39:28]

Change committed as 152047