Issue 10837234: Re-enable login tests under ASAN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837234: Re-enable login tests under ASAN (Closed)

Created:
8 years, 4 months ago by Dmitry Polukhin

Modified:
8 years, 4 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Re-enable login tests under ASAN BUG=126224 TEST=tests pass under ASAN locally and on try bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151536

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -23 lines)			Patch
	M	chrome/browser/chromeos/login/existing_user_controller_browsertest.cc	View		3 chunks	+3 lines, -16 lines	0 comments	Download
	M	chrome/browser/ui/webui/options2/chromeos/guest_mode_options_ui_browsertest.cc	View		1 chunk	+1 line, -7 lines	0 comments	Download

Total messages: 6 (0 generated)

Dmitry Polukhin

Now these test passes locally and on bots so I just re-enable them.

8 years, 4 months ago (2012-08-14 12:13:43 UTC) #1

Alexander Potapenko

On 2012/08/14 12:13:43, Dmitry Polukhin wrote: > Now these test passes locally and on bots ...

8 years, 4 months ago (2012-08-14 12:34:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/10837234/1

8 years, 4 months ago (2012-08-14 12:41:47 UTC) #3

commit-bot: I haz the power

Commit queue rejected this change because the description was changed between the time the change ...

8 years, 4 months ago (2012-08-14 15:00:57 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/10837234/1

8 years, 4 months ago (2012-08-14 15:09:13 UTC) #5

Change committed as 151536