Move StoragePartition into content/public and remove BrowserContext::GetDOMStorageContext().

content/browser/web_contents/web_contents_impl.cc

Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index d5a09dcbb874a55aa40e394cedb5f2975d3edf94..2f6d5e7dbb47b9d9ee928b66941f3abdec638eac 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -54,6 +54,7 @@
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/resource_request_details.h"
+#include "content/public/browser/storage_partition.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents_delegate.h"
 #include "content/public/browser/web_contents_observer.h"
@@ -1233,10 +1234,11 @@ void WebContentsImpl::CreateNewWindow(
       content::GetContentClient()->browser()->
           GetStoragePartitionIdForSiteInstance(GetBrowserContext(),
                                                site_instance);
+  content::StoragePartition* partition =
+          BrowserContext::GetStoragePartition(GetBrowserContext(),

[Charlie Reis, 2012/08/14 18:50:12]

I guess this is another case where it would be useful to expose
GetStoragePartitionById.  Maybe it's worth it.  (Note my attempt at a shorter
name, which you're free to shoot down.)  :)

nit: Wrong indent here.

[awong, 2012/08/14 19:12:47]

Shorter name is better.  :) But decided to punt on this.  Fixed indent.

+                                              site_instance);
   DOMStorageContextImpl* dom_storage_context =
-      static_cast<DOMStorageContextImpl*>(
-          BrowserContext::GetDOMStorageContextByPartitionId(
-              GetBrowserContext(), partition_id));
+      static_cast<DOMStorageContextImpl*>(partition->GetDOMStorageContext());
   SessionStorageNamespaceImpl* session_storage_namespace_impl =
       static_cast<SessionStorageNamespaceImpl*>(session_storage_namespace);
   CHECK(session_storage_namespace_impl->IsFromContext(dom_storage_context));