Move StoragePartition into content/public and remove BrowserContext::GetDOMStorageContext().

content/browser/renderer_host/render_process_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_BROWSER_RENDER_PROCESS_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_BROWSER_RENDER_PROCESS_HOST_IMPL_H_
 
 #include <map>
 #include <queue>
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/process.h"
 #include "base/timer.h"
 #include "content/browser/child_process_launcher.h"
 #include "content/common/content_export.h"
 #include "content/public/browser/render_process_host.h"
 #include "ipc/ipc_channel_proxy.h"
 #include "ui/surface/transport_dib.h"
 
 class CommandLine;
 
 namespace content {
 class GpuMessageFilter;
 class RendererMainThread;
 class RenderWidgetHelper;
 class RenderWidgetHost;
 class RenderWidgetHostImpl;
+class StoragePartitionImpl;
 
 // Implements a concrete RenderProcessHost for the browser process for talking
 // to actual renderer processes (as opposed to mocks).
 //
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 //
 // This object is refcounted so that it can release its resources when all
 // hosts using it go away.
 //
 // This object communicates back and forth with the RenderProcess object
 // running in the renderer process. Each RenderProcessHost and RenderProcess
 // keeps a list of RenderView (renderer) and WebContentsImpl (browser) which
 // are correlated with IDs. This way, the Views and the corresponding ViewHosts
 // communicate through the two process objects.
 class CONTENT_EXPORT RenderProcessHostImpl

[Charlie Reis, 2012/08/14 18:50:12]

Can you add something about the RenderProcessHost being dedicated to a given
StoragePartition here in the class-level comment?  That will make it clear why
it takes one in the constructor.

[awong, 2012/08/14 19:12:47]

Done.

     : public RenderProcessHost,
       public ChildProcessLauncher::Client {
  public:
-  RenderProcessHostImpl(BrowserContext* browser_context, bool is_guest);
+  RenderProcessHostImpl(BrowserContext* browser_context,
+                        StoragePartitionImpl* storage_partition_impl,

[Charlie Reis, 2012/08/14 18:50:12]

Why is this a StoragePartitionImpl rather than a StoragePartition?  Looks like
we only use the public API.

[awong, 2012/08/14 19:12:47]

We get covariant return which removes the need to downcast
DOMStorageContextImpl, IndexDBContextImp, and ChromeAppCacheService in the
implementation.

+                        bool is_guest);
   virtual ~RenderProcessHostImpl();
 
   // RenderProcessHost implementation (public portion).
   virtual void EnableSendQueue() OVERRIDE;
   virtual bool Init() OVERRIDE;
   virtual int GetNextRoutingID() OVERRIDE;
   virtual void CancelResourceRequests(int render_widget_id) OVERRIDE;
   virtual void CrossSiteSwapOutACK(const ViewMsg_SwapOut_Params& params)
       OVERRIDE;
   virtual bool WaitForBackingStoreMsg(int render_widget_id,
@@ skipping 193 matching lines @@
   // instead of in the channel so that we ensure they're sent after init related
   // messages that are sent once the process handle is available.  This is
   // because the queued messages may have dependencies on the init messages.
   std::queue<IPC::Message*> queued_messages_;
 
   // The globally-unique identifier for this RPH.
   int id_;
 
   BrowserContext* browser_context_;
 
+  // Owned by |browser_context_|.
+  StoragePartitionImpl* storage_partition_impl_;
+
   // True if the process can be shut down suddenly.  If this is true, then we're
   // sure that all the RenderViews in the process can be shutdown suddenly.  If
   // it's false, then specific RenderViews might still be allowed to be shutdown
   // suddenly by checking their SuddenTerminationAllowed() flag.  This can occur
   // if one WebContents has an unload event listener but another WebContents in
   // the same process doesn't.
   bool sudden_termination_allowed_;
 
   // Set to true if we shouldn't send input events.  We actually do the
   // filtering for this at the render widget level.
   bool ignore_input_events_;
 
   // Records the last time we regarded the child process active.
   base::TimeTicks child_process_activity_time_;
 
   // Indicates whether this is a RenderProcessHost of a Browser Plugin guest
   // renderer.
   bool is_guest_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderProcessHostImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_BROWSER_RENDER_PROCESS_HOST_IMPL_H_