Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 10837226: Use NDK r8b and 64-bit toolchain (Closed)

Created:
8 years, 4 months ago by michaelbai
Modified:
8 years, 4 months ago
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org
Visibility:
Public.

Description

Use NDK r8b and 64-bit toolchain - Roll DEPS to NDK r8b - Use 64-bit toolchain - Use gold linker BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152376

Patch Set 1 #

Patch Set 2 : Sync with downstream. #

Patch Set 3 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/android/envsetup.sh View 1 chunk +1 line, -1 line 0 comments Download
M build/android/envsetup_functions.sh View 1 4 chunks +16 lines, -5 lines 0 comments Download
M build/common.gypi View 1 2 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
michaelbai
Hi Peter, Would you like to check whether there is issue for WebKit?
8 years, 4 months ago (2012-08-13 22:44:03 UTC) #1
Yaron
Can you land this downstream first or at least in parallel so we know it ...
8 years, 4 months ago (2012-08-13 23:15:18 UTC) #2
michaelbai
On 2012/08/13 23:15:18, Yaron wrote: > Can you land this downstream first or at least ...
8 years, 4 months ago (2012-08-14 02:41:03 UTC) #3
Peter Beverloo
Hi Michael! Thank you for poking me. LGTM for WebKit - it works fine there ...
8 years, 4 months ago (2012-08-14 14:24:26 UTC) #4
michaelbai
I will send a email out to let people, run the envsetup.sh in a new ...
8 years, 4 months ago (2012-08-14 16:39:09 UTC) #5
yfriedman
FWIW, Armand did mail chromium-dev about removing that variable in the mail "Upstream SDK/NDK now ...
8 years, 4 months ago (2012-08-14 17:06:10 UTC) #6
michaelbai
I thought the error Peter got caused by he didn't run the envsetup.sh not the ...
8 years, 4 months ago (2012-08-14 17:27:54 UTC) #7
michaelbai
Synced with downstream, PTAL
8 years, 4 months ago (2012-08-17 21:24:34 UTC) #8
Yaron
lg but let's wait to land on Monday
8 years, 4 months ago (2012-08-17 23:25:35 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 4 months ago (2012-08-20 16:34:47 UTC) #10
Yaron
lgtm
8 years, 4 months ago (2012-08-20 16:36:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10837226/7
8 years, 4 months ago (2012-08-20 16:36:41 UTC) #12
commit-bot: I haz the power
Change committed as 152376
8 years, 4 months ago (2012-08-20 20:09:49 UTC) #13
yongsheng
8 years, 4 months ago (2012-08-21 09:04:43 UTC) #14
On 2012/08/20 20:09:49, I haz the power (commit-bot) wrote:
> Change committed as 152376
hi, michaelbai
it seems the official ndk r8b from android developer website doesn't have the
'linux-x86_64' directory for ARM. so chrome for android build won't support that
but only support ndk under third_party/android_tools/ndk?

Powered by Google App Engine
This is Rietveld 408576698