Add RevokeFileSystem back to IsolatedContext

Add RevokeFileSystem back to IsolatedContext

We deprecated it when we added RevokeFileSystemByPath but it looks we still want it.

BUG=none
TEST=IsolatedContextTest.RegisterAndRevokeTest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151256

[kinuko, 2012-08-13 08:48:26]

Per email with Steve it looks like we still need it. PTL thanks!

[tzik, 2012-08-13 09:03:32]

Now looking.

http://codereview.chromium.org/10837217/diff/1/webkit/fileapi/isolated_contex...
File webkit/fileapi/isolated_context.cc (right):

http://codereview.chromium.org/10837217/diff/1/webkit/fileapi/isolated_contex...
webkit/fileapi/isolated_context.cc:313: bool
IsolatedContext::UnregisterFileSystem(const std::string& filesystem_id) {
Could you add some assertion like this (maybe in separate CL)?
lock_.AssertAcquired();

[kinuko, 2012-08-13 09:20:26]

http://codereview.chromium.org/10837217/diff/1/webkit/fileapi/isolated_contex...
File webkit/fileapi/isolated_context.cc (right):

http://codereview.chromium.org/10837217/diff/1/webkit/fileapi/isolated_contex...
webkit/fileapi/isolated_context.cc:313: bool
IsolatedContext::UnregisterFileSystem(const std::string& filesystem_id) {
On 2012/08/13 09:03:32, tzik wrote:
> Could you add some assertion like this (maybe in separate CL)?
> lock_.AssertAcquired();

Good idea! Done.

http://codereview.chromium.org/10837217/diff/7002/webkit/fileapi/isolated_con...
File webkit/fileapi/isolated_context.cc (right):

http://codereview.chromium.org/10837217/diff/7002/webkit/fileapi/isolated_con...
webkit/fileapi/isolated_context.cc:191: return
UnregisterFileSystem(filesystem_id);
Changed the mysterious argument name to our usual one.

[tzik, 2012-08-13 09:26:09]

lgtm

[commit-bot: I haz the power, 2012-08-13 12:19:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/10837217/7002

[commit-bot: I haz the power, 2012-08-13 13:43:48]

Change committed as 151256