Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: sync/notifier/chrome_invalidation_client.cc

Issue 10837214: Refactor ModelTypePayloadMap and ObjectIdPayloadMap to StateMaps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/notifier/chrome_invalidation_client.h ('k') | sync/notifier/chrome_invalidation_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/notifier/chrome_invalidation_client.cc
diff --git a/sync/notifier/chrome_invalidation_client.cc b/sync/notifier/chrome_invalidation_client.cc
index 6ec46595a0df5420ca9f347dc42252cc9779bf22..e2f406d7760f4d16003fce73b442046b1544af31 100644
--- a/sync/notifier/chrome_invalidation_client.cc
+++ b/sync/notifier/chrome_invalidation_client.cc
@@ -162,9 +162,9 @@ void ChromeInvalidationClient::Invalidate(
if (invalidation.has_payload())
payload = invalidation.payload();
- ObjectIdPayloadMap id_payloads;
- id_payloads[id] = payload;
- EmitInvalidation(id_payloads);
+ ObjectIdStateMap id_state_map;
+ id_state_map[id].payload = payload;
+ EmitInvalidation(id_state_map);
// TODO(akalin): We should really acknowledge only after we get the
// updates from the sync server. (see http://crbug.com/78462).
client->Acknowledge(ack_handle);
@@ -178,9 +178,9 @@ void ChromeInvalidationClient::InvalidateUnknownVersion(
DCHECK_EQ(client, invalidation_client_.get());
DVLOG(1) << "InvalidateUnknownVersion";
- ObjectIdPayloadMap id_payloads;
- id_payloads[object_id] = std::string();
- EmitInvalidation(id_payloads);
+ ObjectIdStateMap id_state_map;
+ id_state_map[object_id].payload = std::string();
+ EmitInvalidation(id_state_map);
// TODO(akalin): We should really acknowledge only after we get the
// updates from the sync server. (see http://crbug.com/78462).
client->Acknowledge(ack_handle);
@@ -195,21 +195,21 @@ void ChromeInvalidationClient::InvalidateAll(
DCHECK_EQ(client, invalidation_client_.get());
DVLOG(1) << "InvalidateAll";
- ObjectIdPayloadMap id_payloads;
+ ObjectIdStateMap id_state_map;
for (ObjectIdSet::const_iterator it = registered_ids_.begin();
it != registered_ids_.end(); ++it) {
- id_payloads[*it] = std::string();
+ id_state_map[*it].payload = std::string();
}
- EmitInvalidation(id_payloads);
+ EmitInvalidation(id_state_map);
// TODO(akalin): We should really acknowledge only after we get the
// updates from the sync server. (see http://crbug.com/76482).
client->Acknowledge(ack_handle);
}
void ChromeInvalidationClient::EmitInvalidation(
- const ObjectIdPayloadMap& id_payloads) {
+ const ObjectIdStateMap& id_state_map) {
DCHECK(CalledOnValidThread());
- listener_->OnInvalidate(id_payloads);
+ listener_->OnInvalidate(id_state_map);
}
void ChromeInvalidationClient::InformRegistrationStatus(
« no previous file with comments | « sync/notifier/chrome_invalidation_client.h ('k') | sync/notifier/chrome_invalidation_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698