Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler_unittest.cc

Issue 10837214: Refactor ModelTypePayloadMap and ObjectIdPayloadMap to StateMaps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/push_messaging/push_messaging_invalidati on_handler.h" 5 #include "chrome/browser/extensions/api/push_messaging/push_messaging_invalidati on_handler.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "chrome/browser/extensions/api/push_messaging/push_messaging_invalidati on_handler_delegate.h" 9 #include "chrome/browser/extensions/api/push_messaging/push_messaging_invalidati on_handler_delegate.h"
10 #include "chrome/browser/sync/invalidation_frontend.h" 10 #include "chrome/browser/sync/invalidation_frontend.h"
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 ids.insert(invalidation::ObjectId( 152 ids.insert(invalidation::ObjectId(
153 ipc::invalidation::ObjectSource::CHROME_COMPONENTS, 153 ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
154 "U/dddddddddddddddddddddddddddddddd/0")); 154 "U/dddddddddddddddddddddddddddddddd/0"));
155 ids.insert(invalidation::ObjectId( 155 ids.insert(invalidation::ObjectId(
156 ipc::invalidation::ObjectSource::CHROME_COMPONENTS, 156 ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
157 "U/dddddddddddddddddddddddddddddddd/3")); 157 "U/dddddddddddddddddddddddddddddddd/3"));
158 EXPECT_CALL(delegate_, 158 EXPECT_CALL(delegate_,
159 OnMessage("dddddddddddddddddddddddddddddddd", 0, "payload")); 159 OnMessage("dddddddddddddddddddddddddddddddd", 0, "payload"));
160 EXPECT_CALL(delegate_, 160 EXPECT_CALL(delegate_,
161 OnMessage("dddddddddddddddddddddddddddddddd", 3, "payload")); 161 OnMessage("dddddddddddddddddddddddddddddddd", 3, "payload"));
162 handler_->OnIncomingNotification(ObjectIdSetToPayloadMap(ids, "payload"), 162 handler_->OnIncomingNotification(ObjectIdSetToStateMap(ids, "payload"),
163 syncer::REMOTE_NOTIFICATION); 163 syncer::REMOTE_NOTIFICATION);
164 } 164 }
165 165
166 // Tests that malformed object IDs don't trigger spurious callbacks. 166 // Tests that malformed object IDs don't trigger spurious callbacks.
167 TEST_F(PushMessagingInvalidationHandlerTest, DispatchInvalidObjectIds) { 167 TEST_F(PushMessagingInvalidationHandlerTest, DispatchInvalidObjectIds) {
168 syncer::ObjectIdSet ids; 168 syncer::ObjectIdSet ids;
169 // Completely incorrect format. 169 // Completely incorrect format.
170 ids.insert(invalidation::ObjectId( 170 ids.insert(invalidation::ObjectId(
171 ipc::invalidation::ObjectSource::TEST, 171 ipc::invalidation::ObjectSource::TEST,
172 "Invalid")); 172 "Invalid"));
(...skipping 10 matching lines...) Expand all
183 ipc::invalidation::ObjectSource::CHROME_COMPONENTS, 183 ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
184 "U/ddddddddddddddddddddddddddddddddd/3")); 184 "U/ddddddddddddddddddddddddddddddddd/3"));
185 // Non-numeric subchannel. 185 // Non-numeric subchannel.
186 ids.insert(invalidation::ObjectId( 186 ids.insert(invalidation::ObjectId(
187 ipc::invalidation::ObjectSource::CHROME_COMPONENTS, 187 ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
188 "U/dddddddddddddddddddddddddddddddd/z")); 188 "U/dddddddddddddddddddddddddddddddd/z"));
189 // Subchannel out of range. 189 // Subchannel out of range.
190 ids.insert(invalidation::ObjectId( 190 ids.insert(invalidation::ObjectId(
191 ipc::invalidation::ObjectSource::CHROME_COMPONENTS, 191 ipc::invalidation::ObjectSource::CHROME_COMPONENTS,
192 "U/dddddddddddddddddddddddddddddddd/4")); 192 "U/dddddddddddddddddddddddddddddddd/4"));
193 handler_->OnIncomingNotification(ObjectIdSetToPayloadMap(ids, "payload"), 193 handler_->OnIncomingNotification(ObjectIdSetToStateMap(ids, "payload"),
194 syncer::REMOTE_NOTIFICATION); 194 syncer::REMOTE_NOTIFICATION);
195 } 195 }
196 196
197 } // namespace extensions 197 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698