Issue 10837210: ash: Copy more files from views/.

Issue 10837210: ash: Copy more files from views/. (Closed)

Created:
8 years, 4 months ago by tfarina

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Copy more files from views/. BUG=125846 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151179

Patch Set 1 #

Patch Set 2 : fix DEPS #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-3 lines, --5 lines)			Patch
M	chrome/browser/ui/DEPS	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	chrome/browser/ui/ash/user_action_handler.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/ash/user_action_handler.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/ash/window_positioner.h	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/ash/window_positioner.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/ash/window_positioner_unittest.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 4 months ago (2012-08-13 15:29:21 UTC) #2

lgtm


On Fri, Aug 10, 2012 at 6:42 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> TBRing...
>
> Description:
> ash: Copy more files from views/.
>
> BUG=125846
> TBR=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/10837210/<http://codereview.chromium.org/108...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   A + chrome/browser/ui/ash/user_**action_handler.h
>   A + chrome/browser/ui/ash/user_**action_handler.cc
>   A + chrome/browser/ui/ash/window_**positioner.h
>   A + chrome/browser/ui/ash/window_**positioner.cc
>   A + chrome/browser/ui/ash/window_**positioner_unittest.cc
>
>
> Index: chrome/browser/ui/ash/user_**action_handler.cc
> diff --git a/chrome/browser/ui/views/ash/**user_action_handler.cc
> b/chrome/browser/ui/ash/user_**action_handler.cc
> similarity index 100%
> copy from chrome/browser/ui/views/ash/**user_action_handler.cc
> copy to chrome/browser/ui/ash/user_**action_handler.cc
> Index: chrome/browser/ui/ash/user_**action_handler.h
> diff --git a/chrome/browser/ui/views/ash/**user_action_handler.h
> b/chrome/browser/ui/ash/user_**action_handler.h
> similarity index 100%
> copy from chrome/browser/ui/views/ash/**user_action_handler.h
> copy to chrome/browser/ui/ash/user_**action_handler.h
> Index: chrome/browser/ui/ash/window_**positioner.cc
> diff --git a/chrome/browser/ui/views/ash/**window_positioner.cc
> b/chrome/browser/ui/ash/**window_positioner.cc
> similarity index 100%
> copy from chrome/browser/ui/views/ash/**window_positioner.cc
> copy to chrome/browser/ui/ash/window_**positioner.cc
> Index: chrome/browser/ui/ash/window_**positioner.h
> diff --git a/chrome/browser/ui/views/ash/**window_positioner.h
> b/chrome/browser/ui/ash/**window_positioner.h
> similarity index 100%
> copy from chrome/browser/ui/views/ash/**window_positioner.h
> copy to chrome/browser/ui/ash/window_**positioner.h
> Index: chrome/browser/ui/ash/window_**positioner_unittest.cc
> diff --git a/chrome/browser/ui/views/ash/**window_positioner_unittest.cc
> b/chrome/browser/ui/ash/**window_positioner_unittest.cc
> similarity index 100%
> copy from chrome/browser/ui/views/ash/**window_positioner_unittest.cc
> copy to chrome/browser/ui/ash/window_**positioner_unittest.cc
>
>
>

Expand Messages | Collapse Messages