Add NaCl smoke test to browser_tests.

chrome/test/data/nacl/nacl_test_data.gyp

Index: chrome/test/data/nacl/nacl_test_data.gyp
diff --git a/chrome/test/data/nacl/nacl_test_data.gyp b/chrome/test/data/nacl/nacl_test_data.gyp
new file mode 100644
index 0000000000000000000000000000000000000000..dc45c6a9f12f9d9b79aaa38329887d888cd05a74
--- /dev/null
+++ b/chrome/test/data/nacl/nacl_test_data.gyp
@@ -0,0 +1,101 @@
+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'includes': [
+    '../../../../native_client/build/untrusted.gypi',
+  ],
+  'targets': [

[bradn, 2012/08/13 21:10:59]

This is pretty much what I recalled.
A comment to note its in need of being refactored to a common file?

[Nick Bray (chromium), 2012/08/13 23:16:26]

Done.

+    {
+      'target_name': 'nacl_tests',
+      'type': 'none',
+      'dependencies': [
+         '../../../../ppapi/ppapi_untrusted.gyp:ppapi_cpp_lib',
+         '../../../../ppapi/native_client/native_client.gyp:ppapi_lib',
+         '../../../../ppapi/native_client/native_client.gyp:nacl_irt',
+      ],
+      'copies': [
+        {
+          'destination': '<(PRODUCT_DIR)/nacl_test_data/newlib',
+          'files': [
+            'nacl_load_test.html',
+            'simple.nmf'
+          ],
+        },
+        {
+          'destination': '<(PRODUCT_DIR)/nacl_test_data/glibc',
+          'files': [
+            'nacl_load_test.html',
+          ],
+        },
+      ],
+      'variables': {
+        'nexe_target': 'simple',
+        'build_newlib': 1,
+        'out_newlib32': '<(PRODUCT_DIR)/nacl_test_data/newlib/>(nexe_target)_newlib_x32.nexe',

[Mark Seaborn, 2012/08/13 22:16:59]

Stupid question: is it really necessary to list all output architectures?

[Nick Bray (chromium), 2012/08/13 23:16:26]

Long term, no.  Short term, yes.  This is how we change the target directories.
:/

+        'out_newlib64': '<(PRODUCT_DIR)/nacl_test_data/newlib/>(nexe_target)_newlib_x64.nexe',
+        'out_newlib_arm': '<(PRODUCT_DIR)/nacl_test_data/newlib/>(nexe_target)_newlib_arm.nexe',
+        'out_glibc32': '<(PRODUCT_DIR)/nacl_test_data/glibc/>(nexe_target)_glibc_x32.nexe',
+        'out_glibc64': '<(PRODUCT_DIR)/nacl_test_data/glibc/>(nexe_target)_glibc_x64.nexe',
+        'out_glibc_arm': '<(PRODUCT_DIR)/nacl_test_data/glibc/>(nexe_target)_glibc_arm.nexe',
+        'include_dirs': [
+          '../../../..',
+        ],
+        'link_flags': [
+          '-lppapi_cpp',
+          '-lppapi',
+          '-lplatform',

[Mark Seaborn, 2012/08/13 22:16:59]

AFAICT, you don't use libplatform or libgio in the test you're adding.  (You
don't use libpthread directly but it's probably still needed by "-lppapi".)

[Nick Bray (chromium), 2012/08/13 23:16:26]

Done.

+          '-lpthread',
+          '-lgio',
+        ],
+        'sources': [
+          'simple.cc',
+        ],
+      },
+      'conditions': [
+        ['target_arch!="arm"', {
+          'variables': {
+            'compile_flags': [
+              '-mno-tls-use-call',

[Mark Seaborn, 2012/08/13 22:16:59]

Why is this here?  It looks like it has been cargo-culted.  This is only for use
inside the IRT.

[Nick Bray (chromium), 2012/08/13 23:16:26]

Done.

+            ],
+          },
+        }],
+        ['target_arch!="arm" and disable_glibc==0', {
+          'variables': {
+            'build_glibc': 1,
+            # NOTE: Use /lib, not /lib64 here; it is a symbolic link which
+            # doesn't work on Windows.
+            'libdir_glibc64': '>(nacl_glibc_tc_root)/x86_64-nacl/lib',
+            'libdir_glibc32': '>(nacl_glibc_tc_root)/x86_64-nacl/lib32',
+            'nacl_objdump': '>(nacl_glibc_tc_root)/bin/x86_64-nacl-objdump',
+            'nmf_glibc%': '<(PRODUCT_DIR)/nacl_test_data/glibc/>(nexe_target).nmf',
+          },
+          'actions': [
+          {
+            'action_name': 'Generate GLIBC NMF and copy libs',
+            'inputs': ['>(out_glibc64)', '>(out_glibc32)'],
+            # NOTE: There is no explicit dependency for the lib32
+            # and lib64 directories created in the PRODUCT_DIR.
+            # They are created as a side-effect of NMF creation.
+            'outputs': ['>(nmf_glibc)'],
+            'action': [
+              'python',
+              '<(DEPTH)/native_client_sdk/src/tools/create_nmf.py',
+              '>@(_inputs)',
+              '--objdump=>(nacl_objdump)',
+              '--library-path=>(libdir_glibc64)',
+              '--library-path=>(libdir_glibc32)',
+              '--output=>(nmf_glibc)',
+              '--stage-dependencies=<(PRODUCT_DIR)/nacl_test_data/glibc',
+              '--toolchain=glibc',
+            ],
+          },
+        ],
+        }],
+      ],
+    },
+  ],
+
+}
+