Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: media/base/media_log.cc

Issue 10837206: Rewrite media::Pipeline state transition machinery and simplify shutdown. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: nits Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/media_log.h ('k') | media/base/pipeline.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/media_log.cc
diff --git a/media/base/media_log.cc b/media/base/media_log.cc
index e47286d002212e846e2cf432faa1192c2bc5ce1e..cadf29105489e241357ca7a2d678771cf53b16af 100644
--- a/media/base/media_log.cc
+++ b/media/base/media_log.cc
@@ -59,37 +59,6 @@ const char* MediaLog::EventTypeToString(MediaLogEvent::Type type) {
return NULL;
}
-const char* MediaLog::PipelineStateToString(Pipeline::State state) {
- switch (state) {
- case Pipeline::kCreated:
- return "created";
- case Pipeline::kInitDemuxer:
- return "initDemuxer";
- case Pipeline::kInitAudioDecoder:
- return "initAudioDecoder";
- case Pipeline::kInitAudioRenderer:
- return "initAudioRenderer";
- case Pipeline::kInitVideoRenderer:
- return "initVideoRenderer";
- case Pipeline::kPausing:
- return "pausing";
- case Pipeline::kSeeking:
- return "seeking";
- case Pipeline::kFlushing:
- return "flushing";
- case Pipeline::kStarting:
- return "starting";
- case Pipeline::kStarted:
- return "started";
- case Pipeline::kStopping:
- return "stopping";
- case Pipeline::kStopped:
- return "stopped";
- }
- NOTREACHED();
- return NULL;
-}
-
const char* MediaLog::PipelineStatusToString(PipelineStatus status) {
switch (status) {
case PIPELINE_OK:
@@ -106,8 +75,6 @@ const char* MediaLog::PipelineStatusToString(PipelineStatus status) {
return "pipeline: abort";
case PIPELINE_ERROR_INITIALIZATION_FAILED:
return "pipeline: initialization failed";
- case PIPELINE_ERROR_REQUIRED_FILTER_MISSING:
- return "pipeline: required filter missing";
case PIPELINE_ERROR_COULD_NOT_RENDER:
return "pipeline: could not render";
case PIPELINE_ERROR_READ:
@@ -182,7 +149,7 @@ scoped_ptr<MediaLogEvent> MediaLog::CreatePipelineStateChangedEvent(
Pipeline::State state) {
scoped_ptr<MediaLogEvent> event(
CreateEvent(MediaLogEvent::PIPELINE_STATE_CHANGED));
- event->params.SetString("pipeline_state", PipelineStateToString(state));
+ event->params.SetString("pipeline_state", Pipeline::GetStateString(state));
return event.Pass();
}
« no previous file with comments | « media/base/media_log.h ('k') | media/base/pipeline.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698