Issue 10837199: OMX: Make context current before using EGLImage functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837199: OMX: Make context current before using EGLImage functions. (Closed)

Created:
8 years, 4 months ago by marcheu

Modified:
8 years, 4 months ago

Reviewers:
Ami GONE FROM CHROMIUM, Pawel Osciak, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, feature-media-reviews_chromium.org

Base URL:
https://git.chromium.org/git/chromium/src@git-svn

Visibility:
Public.

More Reviews

Description

OMX: Make context current before using EGLImage functions. Otherwise we might be on a different context and that triggers invalid drawable errors. BUG=none TEST=by hand, open an html5 video, reload it a bunch of times, close it, TEST=check for no weird invalid drawable error messages. Change-Id: Icc20efa35daf988edb1ecb2cb572e5b484719b35 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150991

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -6 lines)			Patch
M	content/common/gpu/media/gpu_video_decode_accelerator.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/common/gpu/media/omx_video_decode_accelerator.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	content/common/gpu/media/omx_video_decode_accelerator.cc	View	4 chunks	+10 lines, -1 line	0 comments	Download
M	content/common/gpu/media/video_decode_accelerator_unittest.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marcheu@chromium.org/10837199/1

8 years, 4 months ago (2012-08-10 02:35:00 UTC) #5

Change committed as 150991

Expand Messages | Collapse Messages