Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3126)

Unified Diff: chrome/browser/ui/views/user_data_dir_dialog_view.cc

Issue 10837198: views: Eliminate a wstring temp variable in UserDataDirDialogView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rm include as well Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/user_data_dir_dialog_view.cc
diff --git a/chrome/browser/ui/views/user_data_dir_dialog_view.cc b/chrome/browser/ui/views/user_data_dir_dialog_view.cc
index e673902fc35a03869319b9f620f0f0a0800e32b0..8689f42e8f1f5dcffaacc3fb0164751a1ae858e7 100644
--- a/chrome/browser/ui/views/user_data_dir_dialog_view.cc
+++ b/chrome/browser/ui/views/user_data_dir_dialog_view.cc
@@ -6,7 +6,6 @@
#include "base/logging.h"
#include "base/run_loop.h"
-#include "base/utf_string_conversions.h"
#include "chrome/browser/ui/chrome_select_file_policy.h"
#include "chrome/browser/ui/user_data_dir_dialog.h"
#include "grit/chromium_strings.h"
@@ -56,14 +55,13 @@ void UserDataDirDialogView::DeleteDelegate() {
}
bool UserDataDirDialogView::Accept() {
- // Directory picker
- std::wstring dialog_title = UTF16ToWide(l10n_util::GetStringUTF16(
- IDS_CANT_WRITE_USER_DIRECTORY_CHOOSE_DIRECTORY_BUTTON));
+ // Directory picker.
HWND owning_hwnd =
GetAncestor(message_box_view_->GetWidget()->GetNativeView(), GA_ROOT);
select_file_dialog_->SelectFile(ui::SelectFileDialog::SELECT_FOLDER,
- dialog_title, FilePath(), NULL, 0,
- FilePath::StringType(), owning_hwnd, NULL);
+ l10n_util::GetStringUTF16(
+ IDS_CANT_WRITE_USER_DIRECTORY_CHOOSE_DIRECTORY_BUTTON), FilePath(),
+ NULL, 0, FilePath::StringType(), owning_hwnd, NULL);
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698