chrome/browser/tab_contents/render_view_context_menu.cc - Issue 10837192: Speculative revert to see if this change introduced a performance regression on Mac intl perf bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 10837192: Speculative revert to see if this change introduced a performance regression on Mac intl perf bots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sessions/tab_restore_service_delegate.h ('k') | chrome/browser/tab_contents/web_drag_bookmark_handler_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/render_view_context_menu.cc

===================================================================

--- chrome/browser/tab_contents/render_view_context_menu.cc (revision 150796)

+++ chrome/browser/tab_contents/render_view_context_menu.cc (working copy)

@@ -1720,8 +1720,7 @@

case IDC_CONTENT_CONTEXT_VIEWPAGEINFO: {

NavigationController* controller = &source_web_contents_->GetController();

NavigationEntry* nav_entry = controller->GetActiveEntry();

- Browser* browser =

- browser::FindBrowserWithWebContents(source_web_contents_);

+ Browser* browser = browser::FindBrowserForController(controller, NULL);

chrome::ShowPageInfo(browser, source_web_contents_, nav_entry->GetURL(),

nav_entry->GetSSL(), true);

break;

@@ -1762,8 +1761,8 @@

break;

case IDC_CONTENT_CONTEXT_VIEWFRAMEINFO: {

- Browser* browser = browser::FindBrowserWithWebContents(

- source_web_contents_);

+ Browser* browser = browser::FindBrowserForController(

+ &source_web_contents_->GetController(), NULL);

chrome::ShowPageInfo(browser, source_web_contents_, params_.frame_url,

params_.security_info, false);

break;