Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10837192: Speculative revert to see if this change introduced a performance regression on Mac intl perf bots. (Closed)

Created:
8 years, 4 months ago by Ben Goodger (Google)
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, dyu1, tfarina, ajwong+watch_chromium.org, dhollowa+watch_chromium.org, brettw-cc_chromium.org, kkania, dcheng, marja+watch_chromium.org, robertshield, browser-components-watch_chromium.org, estade+watch_chromium.org, gbillock+watch_chromium.org, smckay+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Speculative revert to see if this change introduced a performance regression on Mac intl perf bots. If this change was responsible for this regression, it may also have been responsible for http://crbug.com/133762 http://crbug.com/138260 TEST=mac intl perf bot drops: http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl1/report.html?history=150&rev=-1 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -72 lines) Patch
M chrome/browser/autofill/autofill_feedback_infobar_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sessions/session_restore.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_browsertest.cc View 14 chunks +13 lines, -17 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service_delegate.h View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_gtk.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/web_drag_bookmark_handler_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/tab_restore_service_delegate_android.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_finder.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_finder.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_tab_restore_service_delegate.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_tab_strip_model_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
MM chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/sad_tab_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
MM chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
8 years, 4 months ago (2012-08-09 21:21:29 UTC) #1
sky
8 years, 4 months ago (2012-08-09 21:33:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698