Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 10837182: Add inline annotation for base::MakeCriticalClosure() in platform other than ios. (Closed)

Created:
8 years, 4 months ago by Chen Yu
Modified:
8 years, 4 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add inline annotation for base::MakeCriticalClosure() in platform other than ios. The implementation of this method is basically noop in platforms other than ios and it is put in the header file; this change adds inline annotation to avoid duplicate symbol link error on other platforms. BUG=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/critical_closure.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Chen Yu
Starting with stuartmorgan for initial look. Thanks!
8 years, 4 months ago (2012-08-09 09:17:02 UTC) #1
stuartmorgan
LGTM; +mark This follows the pattern of other files in base (and I assume elsewhere) ...
8 years, 4 months ago (2012-08-09 11:23:33 UTC) #2
Mark Mentovai
LGTM
8 years, 4 months ago (2012-08-09 15:36:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chenyu@chromium.org/10837182/1
8 years, 4 months ago (2012-08-09 15:50:25 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 17:26:34 UTC) #5
Change committed as 150831

Powered by Google App Engine
This is Rietveld 408576698