Added reboot phone step to android testers

Added reboot phone step to android testers

- Does not break bot, but attempts to wait until phone boots
- Minor fixes to adb_device_functions

BUG=141899
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152052

[Isaac (away), 2012-08-09 05:57:17]

(untested; trybots are broken)

[bulach, 2012-08-09 12:48:45]

I'm not a 100% sure what problem is this solving but.. rather than doing at the
end, wouldn't it be better to do at the beginning? so that the test run N is
self contained and does not depend on N-1 had rebooted the devices?

[cmp, 2012-08-10 02:21:51]

On 2012/08/09 12:48:45, bulach wrote:
> I'm not a 100% sure what problem is this solving but.. rather than doing at
the
> end, wouldn't it be better to do at the beginning? so that the test run N is
> self contained and does not depend on N-1 had rebooted the devices?

Hey Marcus, afaik, we see 3 out of 10 devices break in such a way that adb
reboot still works (the kernel is responsive) but the tests themselves fail in
hard-to-recover ways.  Isaac, feel free to correct me there if there's a more
refined answer.

I agree about rebooting at the beginning of each build to keep a uniform
behavior.  I think that's a quick change here, but if not, then this CL lgtm.

Isaac, any reason why we couldn't just reboot the phones at the beginning of
every test suite/group run?

[Isaac (away), 2012-08-10 04:56:37]

That's fine.  I put it at the end so people could get faster feedback on if the
bot was going to break.

It's fine to do at beginning but I wish there was an easy way to do it while
we're syncing and downloading build.

[Isaac (away), 2012-08-10 06:40:08]

Patch is almost ready but 
AndroidCommands::Reboot() needs a regex that works with JBO03C.  Will
investigate in the morning.

[bulach, 2012-08-10 11:30:59]

lgtm, thanks for the clarification! just a nit:

https://chromiumcodereview.appspot.com/10837180/diff/5001/build/android/build...
File build/android/buildbot_functions.sh (right):

https://chromiumcodereview.appspot.com/10837180/diff/5001/build/android/build...
build/android/buildbot_functions.sh:294: # Reboot all phones after successful
run and wait for them to start back up
nit: s/after successful run //

[bulach, 2012-08-10 11:34:25]

btw, it'd be nice to add the explanation "we see 3 out of 10 devices break in
such a way that adb
reboot still works (the kernel is responsive) but the tests themselves fail in
hard-to-recover ways.)" to the patch description :)

reason being, we historically added a bunch of one off workarounds, and then it
got really hard to remove then.. hopefully we'll do it better this time! :)

[Isaac (away), 2012-08-17 04:54:53]

sorry marcus, I forgot to do this. I will add it info to the associated bug