Issue 10837179: Fix DEPS failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837179: Fix DEPS failure. (Closed)

Created:
8 years, 4 months ago by tfarina

Modified:
8 years, 4 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix DEPS failure. I missed one include and somehow checkdeps.py didn't complain :/ BUG=125846 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150694

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/ui/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

8 years, 4 months ago (2012-08-09 15:43:20 UTC) #2

LGTM


On Wed, Aug 8, 2012 at 7:41 PM, <tfarina@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> TBRing...
>
> Description:
> Fix DEPS failure.
>
> I missed one include and somehow checkdeps.py didn't complain :/
>
> BUG=125846
> TBR=ben@chromium.org
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10837179/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/ui/DEPS
>
>
> Index: chrome/browser/ui/DEPS
> diff --git a/chrome/browser/ui/DEPS b/chrome/browser/ui/DEPS
> index 8c401440cfef648c900bdb74c63bce**1f8177312a..**
> 12eb17ddbe282bff91ad2f23ef64bd**83aeccc465 100644
> --- a/chrome/browser/ui/DEPS
> +++ b/chrome/browser/ui/DEPS
> @@ -5,6 +5,7 @@ include_rules = [
>   "!chrome/browser/ui/views/ash/**chrome_shell_delegate.h",
>   "!chrome/browser/ui/views/ash/**launcher/browser_launcher_**
> item_controller.h",
>   "!chrome/browser/ui/views/ash/**launcher/chrome_launcher_**
> controller.h",
> + "!chrome/browser/ui/views/ash/**launcher/launcher_favicon_**loader.h",
>   "!chrome/browser/ui/views/ash/**panel_view_aura.h",
>   "!chrome/browser/ui/views/**find_bar_host.h",
>   "!chrome/browser/ui/views/**frame/browser_frame.h",
>
>
>

Expand Messages | Collapse Messages