Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 10837168: Use flock-style lock on Windows to limit number of concurrent links (Closed)

Created:
8 years, 4 months ago by scottmg
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com, ukai
Visibility:
Public.

Description

Use flock-style lock on Windows to limit number of concurrent links This is mostly for goma builds. Committed: https://code.google.com/p/gyp/source/detail?r=1464

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -8 lines) Patch
M pylib/gyp/win_tool.py View 1 2 3 chunks +28 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
(Tested on cygwin now, seems OK) Someone might want to change to the more fancy ...
8 years, 4 months ago (2012-08-09 16:21:12 UTC) #1
Nico
stampy lgtm You said you wanted to check that this doesn't affect regular build times. ...
8 years, 4 months ago (2012-08-09 17:22:36 UTC) #2
scottmg
On 2012/08/09 17:22:36, Nico wrote: > stampy lgtm > > You said you wanted to ...
8 years, 4 months ago (2012-08-09 17:56:42 UTC) #3
iannucci
8 years, 4 months ago (2012-08-09 18:21:15 UTC) #4
On 2012/08/09 17:56:42, scottmg wrote:
> On 2012/08/09 17:22:36, Nico wrote:
> > stampy lgtm
> > 
> > You said you wanted to check that this doesn't affect regular build times. I
> > assume you did that.
> 
> Yeah, I didn't notice any difference larger (larger than the noise anyway).

FYI, ukai is implementing the general-purpose limiter I wrote for the
msbuild+goma path: https://chromiumcodereview.appspot.com/10827213/

Also, what is the history of win-tool? Is it absolutely necessary for ninja on
windows?

Powered by Google App Engine
This is Rietveld 408576698