WebRequest: Signal end of request if start signaled

WebRequest: Signal end of request if start signaled

Sensitive requests are not usually signaled to extension event handlers
via events like onBeforeRequest.
This is checked by WebRequestPermissions::HideRequest(request).
However, a request might become sensitive after redirect. In that case
it could have been signaled via, e.g., onBeforeRequest, but not any more
via onErrorOcurred or onCompleted.
This causes problems (see BUG for more discussion).

This patch changes the processing of onErrorOccurred and onCompleted so
that even sensitive requests are signaled if they were signaled before.
This is a safe change, because onErrorOccurred and onCompleted handlers
cannot modify the request.

BUG=139982
TEST=Use the extension attached to BUG to log starts and ends of requests. Go to http://goo.gl/fKDKJ which redirects to a sensitive https://chrome.google.com/webstore, and observe that request's start and end being signaled. In general, every request's start and end should be signaled.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150552

[vabr (Chromium), 2012-08-08 10:04:40]

Hi Dominic, PTAL.

[battre, 2012-08-08 11:24:43]

LGTM with nit. Thanks.

http://codereview.chromium.org/10837164/diff/8001/chrome/browser/extensions/a...
File chrome/browser/extensions/api/web_request/web_request_api.h (right):

http://codereview.chromium.org/10837164/diff/8001/chrome/browser/extensions/a...
chrome/browser/extensions/api/web_request/web_request_api.h:375: bool
WasSignaled(const net::URLRequest& request);
nit: const

[commit-bot: I haz the power, 2012-08-08 11:47:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vabr@chromium.org/10837164/1003

[vabr (Chromium), 2012-08-08 11:47:25]

Thanks, addressed the comment and sent to CQ.

Vaclav

http://codereview.chromium.org/10837164/diff/8001/chrome/browser/extensions/a...
File chrome/browser/extensions/api/web_request/web_request_api.h (right):

http://codereview.chromium.org/10837164/diff/8001/chrome/browser/extensions/a...
chrome/browser/extensions/api/web_request/web_request_api.h:375: bool
WasSignaled(const net::URLRequest& request);
On 2012/08/08 11:24:43, battre wrote:
> nit: const

Done.

[commit-bot: I haz the power, 2012-08-08 14:49:03]

Change committed as 150552