Issue 10837152: v8-i18n roll 105:117.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837152: v8-i18n roll 105:117. (Closed)

Created:
8 years, 4 months ago by Nebojša Ćirić

Modified:
8 years, 4 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

v8-i18n roll 105:117. Removes support for v8Locale. ChromeOS has already moved to new v8Intl. BUG=28604 TEST=v8Locale should not exist. ChromeOS should build properly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150842

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (0 generated)

Nebojša Ćirić

ChromeOS already transitioned to v8Intl and I couldn't find any other use sites in non-public ...

8 years, 4 months ago (2012-08-08 20:17:52 UTC) #2

jungshik at Google

hbono, does Google docs use v8Locale API? v8Locale is an old API and v8Intl is ...

8 years, 4 months ago (2012-08-08 21:10:44 UTC) #3

Hironori Bono

Greetings Jungshik, Docs does not use the v8Locale API and it is OK to remove ...

8 years, 4 months ago (2012-08-08 23:57:42 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cira@chromium.org/10837152/1

8 years, 4 months ago (2012-08-09 16:15:34 UTC) #6

Change committed as 150842