Issue 10837149: Don't use NXArgc or NXArgv. Access them via _NSGetArgc() and _NSGetArgv().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837149: Don't use NXArgc or NXArgv. Access them via _NSGetArgc() and _NSGetArgv(). (Closed)

Created:
8 years, 4 months ago by Mark Mentovai

Modified:
8 years, 4 months ago

Reviewers:
Robert Sesek, Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't use NXArgc or NXArgv. Access them via _NSGetArgc() and _NSGetArgv(). This allows dead code stripping to be turned back on for the main executables and for the NXArgc and NXArgv symbols to be stripped. BUG=139902 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150419

Patch Set 1 #

Patch Set 2 : Copyright test #

Patch Set 3 : Make argvp conster #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -35 lines)			Patch
M	chrome/app/app.saves	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/app/app_asan.saves	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/mac/relauncher.cc	View	1 2	3 chunks	+10 lines, -11 lines	1 comment	Download
M	chrome/chrome.gyp	View		1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

8 years, 4 months ago (2012-08-09 01:07:38 UTC) #3

https://chromiumcodereview.appspot.com/10837149/diff/6002/chrome/browser/mac/...
File chrome/browser/mac/relauncher.cc (right):

https://chromiumcodereview.appspot.com/10837149/diff/6002/chrome/browser/mac/...
chrome/browser/mac/relauncher.cc:279: const char* const* const* argvp =
_NSGetArgv();
:-D

Expand Messages | Collapse Messages