Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 10837134: Change the descriptions for Alt+number on the keyboard overlay. (Closed)

Created:
8 years, 4 months ago by mazda
Modified:
8 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Change the descriptions for Alt+number on the keyboard overlay. The behavior of Alt+number was changed by the CL below. http://src.chromium.org/viewvc/chrome?view=rev&revision=148500 BUG=140905 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -45 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 2 chunks +18 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mazda
8 years, 4 months ago (2012-08-07 04:54:55 UTC) #1
xiyuan
lgtm
8 years, 4 months ago (2012-08-07 15:38:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10837134/1
8 years, 4 months ago (2012-08-08 22:11:33 UTC) #3
commit-bot: I haz the power
Try job failure for 10837134-1 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-08 22:46:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10837134/1
8 years, 4 months ago (2012-08-08 23:11:24 UTC) #5
commit-bot: I haz the power
Try job failure for 10837134-1 (retry) on android for steps "compile, build" (clobber build). It's ...
8 years, 4 months ago (2012-08-08 23:54:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10837134/1
8 years, 4 months ago (2012-08-09 01:20:43 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 03:17:29 UTC) #8
Change committed as 150702

Powered by Google App Engine
This is Rietveld 408576698