Issue 10837130: Set locale for extension tests, keep it from affecting global state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10837130: Set locale for extension tests, keep it from affecting global state (Closed)

Created:
8 years, 4 months ago by groby-ooo-7-16

Modified:
8 years, 4 months ago

Reviewers:
Matt Perry, Greg Billock

CC:
chromium-reviews, gbillock+watch_chromium.org, Aaron Boodman, mihaip-chromium-reviews_chromium.org, jshin+watch_chromium.org, smckay+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Set locale for extension tests, keep it from affecting global state R=gbillock@chromium.org,mpcomplete@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150254

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -8 lines)			Patch
M	chrome/browser/extensions/extension_service_unittest.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/intents/cws_intents_registry_unittest.cc	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/common/extensions/extension_l10n_util.h	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_l10n_util.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

Here's the remaining fix for tests depending on global locale state (uncovered in CL 10790087)

8 years, 4 months ago (2012-08-06 22:47:48 UTC) #1

Greg Billock

On 2012/08/06 22:57:18, Matt Perry wrote: > lgtm lgtm

8 years, 4 months ago (2012-08-06 23:01:57 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10837130/1

8 years, 4 months ago (2012-08-07 02:14:05 UTC) #4

Change committed as 150254

Expand Messages | Collapse Messages