Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 10837128: Temporarily ifdef out Active Setup for M22 (Closed)

Created:
8 years, 4 months ago by gab
Modified:
8 years, 4 months ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Temporarily ifdef out Active Setup for M22 BUG=NONE TEST=No Active Setup items installed in registry at system-level Chrome install. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/installer/setup/install_worker.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
gab
PTAL, needs to go in asap.
8 years, 4 months ago (2012-08-06 20:28:42 UTC) #1
robertshield
lgtm
8 years, 4 months ago (2012-08-06 20:47:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/10837128/1
8 years, 4 months ago (2012-08-06 21:20:34 UTC) #3
commit-bot: I haz the power
Try job failure for 10837128-1 (previous was lost) (retry) on linux_rel for step "compile" (clobber ...
8 years, 4 months ago (2012-08-06 22:28:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/10837128/1
8 years, 4 months ago (2012-08-06 22:45:18 UTC) #5
commit-bot: I haz the power
Try job failure for 10837128-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 23:20:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/10837128/1
8 years, 4 months ago (2012-08-07 00:24:31 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 02:16:29 UTC) #8
Change committed as 150237

Powered by Google App Engine
This is Rietveld 408576698