Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5433)

Unified Diff: chrome/browser/ui/gtk/download/download_item_gtk.cc

Issue 10837125: Revert 149794 - DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1228/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/download/download_item_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/download/download_item_gtk.cc (revision 150095)
+++ chrome/browser/ui/gtk/download/download_item_gtk.cc (working copy)
@@ -326,6 +326,9 @@
}
switch (download->GetState()) {
+ case DownloadItem::REMOVING:
+ parent_shelf_->RemoveDownloadItem(this); // This will delete us!
+ return;
case DownloadItem::CANCELLED:
StopDownloadProgress();
gtk_widget_queue_draw(progress_area_.get());
@@ -369,11 +372,6 @@
UpdateStatusLabel(status_text_);
}
-void DownloadItemGtk::OnDownloadDestroyed(DownloadItem* download) {
- parent_shelf_->RemoveDownloadItem(this);
- // This will delete us!
-}
-
void DownloadItemGtk::AnimationProgressed(const ui::Animation* animation) {
if (animation == &complete_animation_) {
gtk_widget_queue_draw(progress_area_.get());
« no previous file with comments | « chrome/browser/ui/gtk/download/download_item_gtk.h ('k') | chrome/browser/ui/views/download/download_item_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698