Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Side by Side Diff: content/browser/download/save_package.cc

Issue 10837125: Revert 149794 - DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1228/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/browser/download/save_package.h ('k') | content/public/browser/download_item.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/download/save_package.h" 5 #include "content/browser/download/save_package.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/file_path.h" 10 #include "base/file_path.h"
(...skipping 1340 matching lines...) Expand 10 before | Expand all | Expand 10 after
1351 1351
1352 void SavePackage::StopObservation() { 1352 void SavePackage::StopObservation() {
1353 DCHECK(download_); 1353 DCHECK(download_);
1354 DCHECK(download_manager_); 1354 DCHECK(download_manager_);
1355 1355
1356 download_->RemoveObserver(this); 1356 download_->RemoveObserver(this);
1357 download_ = NULL; 1357 download_ = NULL;
1358 download_manager_ = NULL; 1358 download_manager_ = NULL;
1359 } 1359 }
1360 1360
1361 void SavePackage::OnDownloadDestroyed(DownloadItem* download) { 1361 void SavePackage::OnDownloadUpdated(DownloadItem* download) {
1362 StopObservation(); 1362 DCHECK(download_);
1363 DCHECK(download_ == download);
1364 DCHECK(download_manager_);
1365
1366 // Check for removal.
1367 if (download_->GetState() == DownloadItem::REMOVING) {
1368 StopObservation();
1369 }
1363 } 1370 }
1364 1371
1365 void SavePackage::FinalizeDownloadEntry() { 1372 void SavePackage::FinalizeDownloadEntry() {
1366 DCHECK(download_); 1373 DCHECK(download_);
1367 DCHECK(download_manager_); 1374 DCHECK(download_manager_);
1368 1375
1369 download_manager_->SavePageDownloadFinished(download_); 1376 download_manager_->SavePageDownloadFinished(download_);
1370 StopObservation(); 1377 StopObservation();
1371 } 1378 }
OLDNEW
« no previous file with comments | « content/browser/download/save_package.h ('k') | content/public/browser/download_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698