Add the screen offset to the location of the flash context menu.

content/renderer/pepper/pepper_plugin_delegate_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_plugin_delegate_impl.h"
 
 #include <cmath>
 #include <cstddef>
 #include <map>
 #include <queue>
@@ skipping 1261 matching lines @@
   ContextMenuParams params;
   params.x = position.x();
   params.y = position.y();
   params.custom_context.is_pepper_menu = true;
   params.custom_context.request_id = request_id;
   params.custom_context.render_widget_id = render_widget_id;
   params.custom_items = menu->menu_data();
 
   // Transform the position to be in render view's coordinates.
   if (instance->view_data().is_fullscreen || instance->flash_fullscreen()) {
-    WebKit::WebRect rect = render_view_->windowRect();
-    params.x -= rect.x;
-    params.y -= rect.y;
+    WebKit::WebRect window_rect = render_view_->windowRect();

[viettrungluu, 2012/08/05 05:55:16]

Are you sure this doesn't break multi-monitor fullscreen for Pepper, non-Flash
fullscreen?

This change feels rather wrong. At the same time, the existing coordinate
transformation feels rather wrong: The render view is interpreting the
coordinates relative to the normal, non-fullscreen window instead of the render
widget's (which is actually in |params| -- so the render view actually knows
which render widget is being targeted).

That said, I'm too lazy to go read code on the renderer host side, and if this
doesn't break anything, it'll do for now.

[raymes, 2012/08/05 06:19:57]

AFAICT this isn't currently used by anything other than flash (the only use I
see is from
http://code.google.com/searchframe#OAMlx_jo-ck/src/webkit/plugins/ppapi/ppb_f...
).  If there is some other non-flash usage, I'm happy to test. I'm not sure
whether it /would/ break non-flash plugins if it were used. 
I agree, but I wasn't sure if this was intended/expected behavior since the
existing code intentionally did the transformation to the windows coordinate
space. I can file a bug to investigate.

+    WebKit::WebRect screen_rect = render_view_->screenInfo().rect;
+    params.x = params.x - window_rect.x + screen_rect.x;
+    params.y = params.y - window_rect.y + screen_rect.y;
   } else {
     params.x += instance->view_data().rect.point.x;
     params.y += instance->view_data().rect.point.y;
   }
 
   IPC::Message* msg = new ViewHostMsg_ContextMenu(render_view_->routing_id(),
                                                   params);
   if (!render_view_->Send(msg)) {
     pending_context_menus_.Remove(request_id);
     return PP_ERROR_FAILED;
@@ skipping 468 matching lines @@
   else
     return render_view_->mouse_lock_dispatcher();
 }
 
 webkit_glue::ClipboardClient*
     PepperPluginDelegateImpl::CreateClipboardClient() const {
   return new RendererClipboardClient;
 }
 
 }  // namespace content