media/mp4/box_reader.h - Issue 10837116: Update EME MediaKeyNeededEvent.initData for ISO BMFF to match current spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mp4/box_reader.h

Issue 10837116: Update EME MediaKeyNeededEvent.initData for ISO BMFF to match current spec. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address review comments. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/mp4/box_reader.h

diff --git a/media/mp4/box_reader.h b/media/mp4/box_reader.h

index 211d99ac6109cb2cb58bf904570343834f53a518..513950e087f7f353c9be69acced38fad6b9d8485 100644

--- a/media/mp4/box_reader.h

+++ b/media/mp4/box_reader.h

@@ -54,8 +54,9 @@ class MEDIA_EXPORT BufferReader {

// Advance the stream by this many bytes.

bool SkipBytes(int nbytes) WARN_UNUSED_RESULT;

- int size() { return size_; }

- int pos() { return pos_; }

+ const uint8* data() const { return buf_; };

ddorwin 2012/09/22 03:25:06 You don't need the last semicolon.

strobe_ 2012/09/22 04:05:33 I just wanted to be sure that my statement was rea

+ int size() const { return size_; };

+ int pos() const { return pos_; };

protected:

const uint8* buf_;

« no previous file with comments | « media/mp4/box_definitions.cc ('k') | media/mp4/mp4_stream_parser.h » ('j') | no next file with comments »