Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10837112: Add WebContents* to some more WebContentsDelegate methods (Closed)

Created:
8 years, 4 months ago by joth
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add WebContents* to some more delegate methods This are required to identify the correct java peer-object on Android BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150470

Patch Set 1 #

Patch Set 2 : fix try servers 1 #

Patch Set 3 : Try 2 #

Patch Set 4 : Try 3 #

Patch Set 5 : try 4 #

Patch Set 6 : try 5 #

Patch Set 7 : try 6 #

Patch Set 8 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -34 lines) Patch
M chrome/browser/chromeos/login/html_page_screen.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/html_page_screen.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/registration_screen.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/registration_screen.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.h View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/debugger/devtools_window.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/debugger/devtools_window.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_host_mac.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_host_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/web_dialog_window_controller.mm View 1 2 3 4 5 6 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/web_dialog_gtk.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/web_dialog_gtk.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_host.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel_host.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.h View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 1 2 3 4 5 6 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_plugin/old/browser_plugin_host.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/old/browser_plugin_host.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/web_contents_delegate.h View 3 chunks +8 lines, -4 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/shell/shell.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/shell_mac.mm View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/controls/webview/web_dialog_view.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/webview/web_dialog_view.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
joth
Hi Avi, CL as per our discussion on content-team https://groups.google.com/a/chromium.org/group/content-team/browse_thread/thread/8f8206fb781c8cd9# Thanks,
8 years, 4 months ago (2012-08-07 00:49:18 UTC) #1
Avi (use Gerrit)
LGTM!
8 years, 4 months ago (2012-08-07 04:15:00 UTC) #2
joth
+ben, could you give a OWNER rubberstamp for all the chrome/* files? Just adding new ...
8 years, 4 months ago (2012-08-07 21:15:34 UTC) #3
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-07 21:21:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joth@chromium.org/10837112/6019
8 years, 4 months ago (2012-08-07 21:25:04 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 00:39:15 UTC) #6 
Change committed as 150470

Powered by Google App Engine
This is Rietveld 408576698