Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 10837100: Android: configure use_system_zlib in zlib.gyp (Closed)

Created:
8 years, 4 months ago by agl
Modified:
8 years, 3 months ago
Reviewers:
klobag.chromium
CC:
chromium-reviews
Visibility:
Public.

Description

Android: configure use_system_zlib in zlib.gyp Currently third_party/zlib/zlib.gyp uses the system libz if: os_posix == 1 and OS != "mac" and OS != "ios" and OS != "openbsd" I'm assuming that Android sets os_posix==1 and therefore this change is a no-op. But it consolidates control of this variable in a single location. BUG=none

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -3 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
agl
8 years, 4 months ago (2012-08-03 18:12:46 UTC) #1
klobag.chromium
lgtm https://chromiumcodereview.appspot.com/10837100/diff/1/build/common.gypi File build/common.gypi (left): https://chromiumcodereview.appspot.com/10837100/diff/1/build/common.gypi#oldcode983 build/common.gypi:983: 'use_system_zlib%': 1, I assume that you have changed ...
8 years, 4 months ago (2012-08-03 23:11:57 UTC) #2
agl
https://chromiumcodereview.appspot.com/10837100/diff/1/build/common.gypi File build/common.gypi (left): https://chromiumcodereview.appspot.com/10837100/diff/1/build/common.gypi#oldcode983 build/common.gypi:983: 'use_system_zlib%': 1, On 2012/08/03 23:11:57, klobag.chromium wrote: > I ...
8 years, 4 months ago (2012-08-06 11:47:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/10837100/1
8 years, 4 months ago (2012-08-06 11:47:55 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-06 12:07:32 UTC) #5
Try job failure for 10837100-1 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698